Skip to content

fix: mark mod as client-side only (fixes #5) #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LinkIsGrim wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: mark mod as client-side only (fixes #5) #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions src/main/java/toni/immersivedamageindicators/ImmersiveDamageIndicators.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@

#if FABRIC
import net.fabricmc.api.ClientModInitializer;
import net.fabricmc.api.ModInitializer;
#if mc >= 215
import fuzs.forgeconfigapiport.fabric.api.v5.ConfigRegistry;
import fuzs.forgeconfigapiport.fabric.api.v5.client.ConfigScreenFactoryRegistry;
Expand Down Expand Up @@ -64,7 +63,7 @@
#if FORGELIKE
@Mod("immersivedamageindicators")
#endif
public class ImmersiveDamageIndicators #if FABRIC implements ModInitializer, ClientModInitializer #endif
public class ImmersiveDamageIndicators #if FABRIC implements ClientModInitializer #endif
{
public static final String MODNAME = "Immersive Damage Indicators";
public static final String ID = "immersivedamageindicators";
Expand Down Expand Up @@ -93,8 +92,11 @@ public ImmersiveDamageIndicators(#if NEO IEventBus modEventBus, ModContainer mod
}


#if FABRIC @Override #endif
public void onInitialize() {
}

#if FABRIC @Override #endif
public void onInitializeClient() {
#if FABRIC
AllConfigs.register((type, spec) -> {
#if mc >= 215
Expand All @@ -105,12 +107,7 @@ public void onInitialize() {
ForgeConfigRegistry.INSTANCE.register(ImmersiveDamageIndicators.ID, type, spec);
#endif
});
#endif
}

#if FABRIC @Override #endif
public void onInitializeClient() {
#if FABRIC
ParticleRegistry.registerFabric();

#if AFTER_21_1
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/META-INF/mods.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@ modId="minecraft"
mandatory=true
versionRange="${mc}"
ordering="NONE"
side="BOTH"
side="CLIENT"

${depends}
2 changes: 1 addition & 1 deletion src/main/resources/META-INF/neoforge.mods.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@ modId="minecraft"
mandatory=true
versionRange="${mc}"
ordering="NONE"
side="BOTH"
side="CLIENT"

${depends}
5 changes: 1 addition & 4 deletions src/main/resources/fabric.mod.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,8 @@
},
"license": "${license}",
"icon": "assets/${id}/textures/mod_logo.png",
"environment": "*",
"environment": "client",
"entrypoints": {
"main": [
"${group}.${namespace}.${name}"
],
"client": [
"${group}.${namespace}.${name}"
],
Expand Down
7 changes: 3 additions & 4 deletions src/main/resources/mixins.immersivedamageindicators.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,12 @@
"compatibilityLevel": "JAVA_17",
"minVersion": "0.8",
"plugin": "toni.immersivedamageindicators.MixinPlugin",
"mixins": [
"LivingEntityMixin",
"PlayerMixin"
],
"mixins": [],
"injectors": {
"defaultRequire": 1
},
"client": [
"LivingEntityMixin",
"PlayerMixin"
]
}