Added Animation, Tilemaps, and many more#24
Open
Lioncub901 wants to merge 22 commits into
Open
Conversation
Collaborator
|
Hey @Lioncub901, sorry for the conflicts, we did a pass to add helptext to every method, attribute, etc. Your conflicts will have to be resolved and missing helptext should be added. Thanks! |
jfperusse
requested changes
Mar 30, 2026
Collaborator
jfperusse
left a comment
jfperusse
left a comment
There was a problem hiding this comment.
General comment:
- Careful with the typos and missing words. Please do a pass on grammar before sending for review. Missing words sometimes makes it confusing.
- Please standardize between "keyframe" or "key frame". I'm not going to list all of them but we should use one, not both. I prefer "keyframe".
- Try to use full sentences, and be consistent with how you end the types descriptions. Right now, they sometimes end with a dot, sometimes not. I'm not going to list all of them either.
- Make sure helptext is added to ALL lua:method / lua:staticmethod / lua:attribute. There is a python script under the scripts folder you can use to list all missing ones.
- As I was nearing 100 comments, I skipped quickly over timemap and time files. Please review them based on my other comments as well.
jfperusse
requested changes
Mar 30, 2026
Collaborator
jfperusse
left a comment
jfperusse
left a comment
There was a problem hiding this comment.
General comment:
- Careful with the typos and missing words. Please do a pass on grammar before sending for review. Missing words sometimes makes it confusing.
- Please standardize between "keyframe" or "key frame". I'm not going to list all of them but we should use one, not both. I prefer "keyframe".
- Try to use full sentences, and be consistent with how you end the types descriptions. Right now, they sometimes end with a dot, sometimes not. I'm not going to list all of them either.
- Make sure helptext is added to ALL lua:method / lua:staticmethod / lua:attribute. There is a python script under the scripts folder you can use to list all missing ones.
- As I was nearing 100 comments, I skipped quickly over timemap and time files. Please review them based on my other comments as well.
Co-authored-by: Jean-François Pérusse <jfperusse@gmail.com>
Co-authored-by: Jean-François Pérusse <jfperusse@gmail.com>
Co-authored-by: Jean-François Pérusse <jfperusse@gmail.com>
Co-authored-by: Jean-François Pérusse <jfperusse@gmail.com>
Co-authored-by: Jean-François Pérusse <jfperusse@gmail.com>
Co-authored-by: Jean-François Pérusse <jfperusse@gmail.com>
Co-authored-by: Jean-François Pérusse <jfperusse@gmail.com>
Co-authored-by: Jean-François Pérusse <jfperusse@gmail.com>
Co-authored-by: Jean-François Pérusse <jfperusse@gmail.com>
Co-authored-by: Jean-François Pérusse <jfperusse@gmail.com>
Co-authored-by: Jean-François Pérusse <jfperusse@gmail.com>
Co-authored-by: Jean-François Pérusse <jfperusse@gmail.com>
Co-authored-by: Jean-François Pérusse <jfperusse@gmail.com>
Co-authored-by: Jean-François Pérusse <jfperusse@gmail.com>
Co-authored-by: Jean-François Pérusse <jfperusse@gmail.com>
Co-authored-by: Jean-François Pérusse <jfperusse@gmail.com>
… reading funcitons
jfperusse
requested changes
Apr 19, 2026
Collaborator
jfperusse
left a comment
jfperusse
left a comment
There was a problem hiding this comment.
A few remaining comments. Note that I did not go through every single helptext added, and one of them was a copy/paste not documenting the right element (I added a comment for it), so please double check that your added helptext are all correct. Thank you!
|
|
||
| .. lua:attribute:: fps: integer | ||
|
|
||
| The frames that are placed pre second |
Collaborator
There was a problem hiding this comment.
@Lioncub901 You don't see to have addressed this one.
|
|
||
| Gets the tracks of the animation | ||
|
|
||
| .. helptext:: checks if the animation is playing |
|
|
||
| .. lua:attribute:: count: integer | ||
|
|
||
| The amount of keyframes in a track |
Collaborator
There was a problem hiding this comment.
@Lioncub901 Please search and replace any "key frame" to "keyframe".
|
|
||
| Enables/disables this gesture recognizer | ||
|
|
||
| .. helptext:: whether the gesture recognizer is enabled |
Collaborator
There was a problem hiding this comment.
Look for other places where you have "whether the gesture recognizer is enabled" and standardize to "get or set if the gesture recognizer is enabled"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.