PLAT-2003/ci: run pre-commit in CI - #49
Merged
Merged
Conversation
This repo has a .pre-commit-config.yaml, including the uv-lock hook added in the PLAT-2003 sweep, but nothing runs pre-commit in CI. So the hooks only fire for developers who have pre-commit installed locally, and a PR that introduces lock drift or a formatting regression goes green. Add the same Style workflow the other repos use, on the consolidated two-inc/actions-public/pre-commit action. The older two-inc/pre-commit-action sets an unauthenticated PIP_EXTRA_INDEX_URL, which makes pip prompt for credentials and die with EOFError on a cold hook cache.
☂️ Code Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
🖌 Pre-commit success 🏆DetailsExit code: 0 Author ✍️@brtkwr |
Puvendhan
approved these changes
Jul 30, 2026
Puvendhan
left a comment
There was a problem hiding this comment.
PLAT-2003 final batch. Verified: group 1 adds only the Style/pre-commit CI workflow (consolidated actions-public/pre-commit, per-repo py pin); lending is project-version-only; webhooks regen matches declared pyproject specifiers (no pydantic-xml present, so the ratatosk break path doesn't apply). Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This repo has a
.pre-commit-config.yaml— including theuv-lockhook added in the PLAT-2003 sweep — but nothing runs pre-commit in CI. There is no Style workflow.So the hooks only fire for developers who happen to have pre-commit installed locally. A PR that introduces lock drift, a formatting regression, or a bandit finding goes green regardless. That makes the hook decoration rather than a guard, which undercuts the point of the sweep: 9 of the 25 repos we added
uv-lockto were in this state.It also produced a false signal during the rollout — two repos with genuine
pyproject/uv.lockdrift showed green CI, because nothing was checking, not because they were in sync.Changes
Styleworkflow, matching the one already used across the org.Scope / Non-goals
two-inc/actions-public/pre-commitaction, not the oldertwo-inc/pre-commit-action. The old one sets an unauthenticatedPIP_EXTRA_INDEX_URLon the pre-commit step, which makes pip prompt for a username and die withEOFErroron a cold hook cache — that is what broke two-avida-client's CI.python-versionis pinned to match this repo'srequires-pythonfloor.Validation
pre-commitrun is the validation: it is the first time these hooks have executed in CI for this repo, so a red result here is a real pre-existing finding rather than a regression.Ticket
🤖 Generated with Claude Code
https://claude.ai/code/session_017VDJqb1XWoNNxZEfGQ8meH