Update dependencies and drop Node.js < 20 support#323
Draft
Conversation
Member
|
Thanks for the ping! I have to admit I'm not deeply familiar with how this package's version is synced to Bootstrap's versions in practice for major versions, so I might be off here (and I won't be able to look into this properly for at least a week, sorry about that). From what I understand though, would something like this make sense?
Does that even make sense as a strategy, or am I missing something? Would love your take before I properly test this config against @mdo you might have some input here too, as the person who has worked the most on the Sass side of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs some work mostly due to the order errors. Unsure how to make it work like before.
The deprecated rules are probably valid and something Bootstrap v6 could benefit, maybe minus the clip error?
/CC @julien-deramond in case you have any ideas.
PS. I had to disable
color-function-alias-notationin scss files because it incorrectly changed things, I think. Feel free to revisit as needed and push to this branch.PPS. There might be other rules we override that could change like dropping
scss/no-global-function-namesandselector-not-notation.