Skip to content

unmountHTMLWhenHide not working #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
olya777 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

unmountHTMLWhenHide not working #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Tooltip/js/tippy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ class Tippy {
if (
isVisible(popper) ||
!appendTo.contains(popper) ||
getComputedStyle(tooltip).opacity === '1'
getComputedStyle(tooltip).opacity !== '1'

@tuanthieu2993 tuanthieu2993 Oct 6, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have had a quick test, your fix seems to make the issue more than fix it, the tooltip in my usual use-case got stuck and never unmount out of DOM.

The original logic seems correct so, again, please help giving more clue / code snippet. Would very appreciate it.

) return

el.removeEventListener('mousemove', followCursorHandler)
Expand Down