Add possibility to cancel from onShow event#139
Open
emilpalsson wants to merge 1 commit into
Open
Conversation
Author
|
I could also happily add the same cancellation option to |
60aa29d to
413b0d2
Compare
Author
|
I would love to hear back from you on this super small and straight forward PR. Thanks! |
|
@emilpalsson why aren't you using the official library? https://github.com/atomiks/tippyjs-react |
Author
|
@atomiks I wasn't aware there was one. Awesome, will definitely look into it! Thanks! |
Author
@atomiks Just wanted to tell you that we've now fully migrated to the official library and our current use case (conditionally show tooltip using the onShow prop) worked out of the box. Thanks alot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like tippy.js does (see code & documentation), allow the
onShowcallback to returnfalseto cancel showing the tooltip.Very useful for conditionally showing the tooltip depending on e.g. if the hovered content is currently overflown or not. I use it like this:
I also added
elas an argument to the callback. If you think that's a bad idea, I'll happily change.