Skip to content

little fixes (php 8 constructors, ignore missing subfeed title) #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wolfgangasdf wants to merge 1 commit into
base: master
Choose a base branch
from
Open

little fixes (php 8 constructors, ignore missing subfeed title) #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion action.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ function register(Doku_Event_Handler $controller) {
'process_feed');
}

function action_plugin_news() {
function __construct() {
global $newsUpdated;
$this->helper = $this->loadHelper('news', true);
}
Expand Down
2 changes: 1 addition & 1 deletion admin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class admin_plugin_news extends DokuWiki_Admin_Plugin {
var $subfeed_selected = 0;
var $subfeed_name = "";

function admin_plugin_news() {
function __construct() {
$this->helper =& plugin_load('helper', 'news');
if($_REQUEST['subfeeds'] != 'NotSet') {
$this->helper->setSubFeed($_REQUEST['subfeeds']);
Expand Down
2 changes: 1 addition & 1 deletion helper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ function pageUpdated(){
function setUpdate($ar = null){
if($ar) {
$this->header = $ar[0];
$this->sub_feed = trim($ar[1]);
$this->sub_feed = trim($ar[1] ?? "");
}
$this->wasUpdated = true;

Expand Down
2 changes: 1 addition & 1 deletion syntax/feed.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
class syntax_plugin_news_feed extends DokuWiki_Syntax_Plugin {
var $helper;
var $is_news_mgr;
function syntax_plugin_news_feed() {
function __construct() {
$this->helper =& plugin_load('helper', 'news');
}
/**
Expand Down