[pull] master from ruby:master#1005
Merged
Merged
Conversation
This is because `make test-bundler-parallel` command, which runs successfully via turbo_tests, does not have `--disable-gems` option specified. `--disable-gems` is currently set in `RUN_OPTS`. Removing it would affect not only test-bundler but the entire test suite, so I have configured it specifically for this command instead. This patch will fix an error in `./spec/bundler/bundler/cli_common_spec.rb` when executing `make test-bundler`. Co-authored-by: Sutou Kouhei <kou@clear-code.com>
We changed how AnyToString worked and no longer need this instruction.
In infer_types, snapshot the types of all branch arguments before writing to any target block param. Previously, when a self-loop's branch args referenced the target's own params (e.g. a phi swap), updating params sequentially could observe values updated earlier in the same loop iteration.
Branch arms (IfTrue, IfFalse, Jump) update target block param types but were not flagging the fixpoint loop's `changed` bit. With a pure shuffle block (no non-branch insns to drive `changed` via their own infer_type), the loop could exit while param types were still widening. Now each branch arm sets `changed = true` whenever the union actually grew a param's type. Add an HIR build test: a self-loop with a 4-cycle param rotation must reach the full union of all four input types at every param, which would previously fall short by one type even with parallel phi semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )