feat: opt into prerelease APK serving - #21
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b8e86c28b7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if meta.Prerelease && !s.opts.IncludePrerelease { | ||
| return nil, fmt.Errorf("cached release %q is a prerelease but RELEASE_INCLUDE_PRERELEASE is disabled", meta.Tag) |
There was a problem hiding this comment.
When a deployment that previously cached a prerelease restarts with RELEASE_INCLUDE_PRERELEASE disabled, this rejection leaves s.current nil. The ensuing refresh therefore skips both monotonicity checks and can download a lower stable tag with a lower versionCode, replacing the newer cached artifact despite the documented no-downgrade guarantee. Keep the rejected prerelease's version metadata as a non-serving monotonic floor, or otherwise prevent a lower stable release from overwriting it.
Useful? React with 👍 / 👎.
1 participant
Summary
Verification
Deployment context
The current signed agent-v0.1.0 GitHub release is a prerelease for controlled testing. This option is required for the Dokploy publicserver to serve that preview without changing the stable default.