Skip to content

Fix release APK metadata check quoting - #19

Merged
turin-dev merged 2 commits into
masterfrom
codex/fix-release-workflow
Aug 26, 2026
Merged

Fix release APK metadata check quoting#19
turin-dev merged 2 commits into
masterfrom
codex/fix-release-workflow

Conversation

@turin-dev

Copy link
Copy Markdown
Owner

Summary

  • fix the release workflow's APK metadata check
  • avoid nested single-quote parsing inside the Docker bash -euc command
  • keep package name and release version assertions on the aapt package line

Verification

  • local Android Docker apksigner simulation passed
  • local aapt package/version assertion passed
  • git diff --check passed

This fixes the failed agent-v0.1.0 run before re-running the tag. No GitHub release was created by the failed run.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1444cefac5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/release.yml Outdated
@turin-dev
turin-dev merged commit 0d175d5 into master Aug 26, 2026
10 checks passed
@turin-dev
turin-dev deleted the codex/fix-release-workflow branch August 26, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant