Skip to content

[BUGFIX] Register Bank has no is_pc #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhilippvK merged 3 commits into from
Jul 29, 2026
Merged

[BUGFIX] Register Bank has no is_pc #114

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8be328
[BUGFIX] Register Bank has no is_pc
MercurCodes Jul 28, 2026
de22eb8
[BugFix] ETISS fix init of reg values
jokap11 Jul 28, 2026
be283cd
[Bugfix] Typo within MAKO
jokap11 Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions m2isar/backends/etiss/templates/etiss_arch_cpp.mako
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,13 +95,15 @@ void ${core_name}Arch::resetCPU(ETISS_CPU *cpu, etiss::uint64 *startpointer)

% for reg in actual_regs:
% if not isinstance(reg, (arch.Memory, arch.Alias)):
% if not reg.is_pc:
% if isinstance(reg.ty, type_info.ArrayType):
% if isinstance(reg, arch.RegisterBank):
<% assert isinstance(reg.ty, type_info.ArrayType) %>
for (int i = 0; i < ${arch.get_const_or_val(reg.ty.length)}; ++i)

@jokap11 jokap11 Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch that my solution was a bit sloppy here.
Excluding RegisterBanks seems a bit contradictory, as we explicitly initialize a RegisterBank in the following three lines.
I would suggest moving the if not reg.is_pc check into the else branch instead.
As ArrayType=RegisterBank and PrimitiveType=Register
Does that fix your issue?
I assume this is also just there to avoid pointing your PC to the Interrupt Vector Table aka 0

@MercurCodes MercurCodes Jul 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me!
Works for me. The problem for me was simply, that if the register bank is not in there, it crashed on the if is_pc check, since the register bank does not support this attribute.

I have rebuilt everything with your solution, so it works for me!
Thanks for fixing it :-)

{
${core_name.lower()}cpu->${reg.name}[i] = 0;
}
% else:
<% assert isinstance(reg.ty, type_info.PrimitiveType) %>
% if not reg.is_pc:
${core_name.lower()}cpu->${reg.name} = 0;
% endif
% endif
Expand Down