Conversation
Port mdv to the Terminal.Gui 2.5.0 preview built from tui-cs/Terminal.Gui#5416 (ConfigurationManager removal), as part of the v2.5.0 ecosystem-validation gate (tui-cs/Terminal.Gui#5630). - TEMP: vendor Terminal.Gui.2.5.0-tig-remove-cm-followup.1 nupkg/snupkg in ./local_packages with a nuget.config source, mirroring tig/winprint#272; swap to the public nuget.org package once 2.5.x ships. - Replace deleted ConfigurationManager.Enable (ConfigLocations.All) with TuiConfigurationBuilder ().ApplyToStaticFacades (). - Suppress new CS0618 on TextMateSyntaxHighlighter.GetThemeForBackground (obsolete in 2.5; still functional) with a follow-up note. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BVbLXNzbus2MTXmiJDBErL
…ba423 followup.1 was built from a stale 5416 commit (93c3b3d4) with real config-load defects fixed later on the branch: CWD-relative ./.tui config was silently ignored, and a malformed config crashed before Main. Verified with followup.2 that a ./.tui/config.json in the launch CWD now applies (Theme=Light takes effect). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BVbLXNzbus2MTXmiJDBErL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR pins a vendored pre-release build (
Terminal.Gui 2.5.0-tig-remove-cm-followup.2, built from tui-cs/Terminal.Gui#5416) so the port can be validated ahead of the v2.5.0 release. Before merging, once a public 2.5.x package is on nuget.org:mdv.csprojlocal_packages/and thetgui-pr-5416package source innuget.config(delete the file if that source is all it adds).gitignoreexception for the vendored packages (if present)Ports mdv to the Terminal.Gui 2.5.0 preview package as part of the v2.5.0 ecosystem-validation gate (tui-cs/Terminal.Gui#5630). Terminal.Gui PR tui-cs/Terminal.Gui#5416 (ConfigurationManager removal) is not yet merged, so this PR vendors a nupkg built from that PR branch — same pattern as tig/winprint#272.
TEMP: vendored package pin
local_packages/carriesTerminal.Gui.2.5.0-tig-remove-cm-followup.2(.nupkg + .snupkg) built from FIXES #4367 - BREAKING CHANGE - Remove legacy ConfigurationManager after MEC migration Terminal.Gui#5416, force-added past the*.nupkggitignore rule.nuget.configadds atgui-pr-5416source pointing at./local_packages.mdv.csprojpinsTerminal.Guito2.5.0-tig-remove-cm-followup.2.Follow-up: once 2.5.x is published to nuget.org, swap the pin to the public package and delete
local_packages/+ thetgui-pr-5416source.Code changes (2.5.0 API breaks fixed)
ConfigurationManager.Enable (ConfigLocations.All)is gone in 2.5. Replaced withnew TuiConfigurationBuilder ().ApplyToStaticFacades (); library defaults,~/.tui,./.tui, andTUI_CONFIGare also applied at assembly load viaTuiConfigurationBuilder.Shared.TextMateSyntaxHighlighter.GetThemeForBackgroundis now[Obsolete](syntax colors resolve fromThemeManager.ThemeviaVisualRole.Code*roles). Still functional; suppressed CS0618 with a follow-up note to migrate the auto light/dark theme selection.No other 2.5.0 breaks hit mdv: it does not override
View.Text(only assigns it) and does not referenceIAcceptTarget, and the repo has noconfig.json.Verification
dotnet build: 0 warnings, 0 errors.mdv --print README.mdrenders the full README with formatting intact; full-screenmdv README.mdshows content, StatusBar (Quit / Content Width / Theme / line count), scrolls, and quits cleanly on Esc — the default Quit key fromApplication.GetDefaultKey (Command.Quit), shown asEsc Quitin the StatusBar. (An earlier revision of this description said Ctrl+Q; Ctrl+Q is not bound — same as rc.3 onmain, verified by cast.) No exceptions in either cast.mdv README.md second.md): File selector dropdown renders in the StatusBar, opens on click, and selecting the second file loads and renders it; clean alt-screen exit on Esc.NUGET_PACKAGES,dotnet restore --forceresolvesTerminal.Gui 2.5.0-tig-remove-cm-followup.2from the vendored./local_packagesfeed.followup.2(built from 5416 head e8aba423):followup.1was built from a stale 5416 commit (93c3b3d4) that silently ignored CWD-relative./.tuiconfig and crashed beforeMainon malformed config. Verified under.2that a./.tui/config.jsonwith{"Theme":"Light"}in the launch CWD now takes effect (tuirec casts show Light-theme colors vs. an identical-config-free baseline).🤖 Generated with Claude Code
https://claude.ai/code/session_01BVbLXNzbus2MTXmiJDBErL