Bump TerminalGuiVersion to 2.4.18-develop.41 (needs fixes) - #286
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8a2df41b6d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| to build against the ../Terminal.Gui enlistment instead (see Directory.Build.targets). | ||
| --> | ||
| <TerminalGuiVersion Condition="'$(TerminalGuiVersion)' == ''">2.4.18-develop.5</TerminalGuiVersion> | ||
| <TerminalGuiVersion Condition="'$(TerminalGuiVersion)' == ''">2.4.18-develop.41</TerminalGuiVersion> |
There was a problem hiding this comment.
Include compatibility fixes before raising the dependency floor
The commit records that validation for this exact dependency bump failed, but it changes only the default pin used by every normal restore and build. Consequently, consumers and CI now receive 2.4.18-develop.41 without the source changes needed to absorb it; keep the previous pin or include the required compatibility fixes so the full build and test suites pass before merging. CLAUDE.mdL25-L25
Useful? React with 👍 / 👎.
Automated bump of
TerminalGuiVersionfrom2.4.18-develop.5to2.4.18-develop.41failed validation (build or tests).Editor needs source changes to absorb this Terminal.Gui update. See the
failed workflow run.