Skip to content

Bump TerminalGuiVersion to 2.4.18-develop.41 (needs fixes) - #286

Closed
tig wants to merge 1 commit into
developfrom
bump/terminal-gui-2.4.18-develop.41
Closed

Bump TerminalGuiVersion to 2.4.18-develop.41 (needs fixes)#286
tig wants to merge 1 commit into
developfrom
bump/terminal-gui-2.4.18-develop.41

Conversation

@tig

@tig tig commented Aug 22, 2026

Copy link
Copy Markdown
Member

Automated bump of TerminalGuiVersion from 2.4.18-develop.5 to 2.4.18-develop.41 failed validation (build or tests).

Editor needs source changes to absorb this Terminal.Gui update. See the
failed workflow run.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8a2df41b6d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Directory.Build.props
to build against the ../Terminal.Gui enlistment instead (see Directory.Build.targets).
-->
<TerminalGuiVersion Condition="'$(TerminalGuiVersion)' == ''">2.4.18-develop.5</TerminalGuiVersion>
<TerminalGuiVersion Condition="'$(TerminalGuiVersion)' == ''">2.4.18-develop.41</TerminalGuiVersion>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Include compatibility fixes before raising the dependency floor

The commit records that validation for this exact dependency bump failed, but it changes only the default pin used by every normal restore and build. Consequently, consumers and CI now receive 2.4.18-develop.41 without the source changes needed to absorb it; keep the previous pin or include the required compatibility fixes so the full build and test suites pass before merging. CLAUDE.mdL25-L25

Useful? React with 👍 / 👎.

@tig

tig commented Aug 22, 2026

Copy link
Copy Markdown
Member Author

Closing as a sibling of #283: auto-bump was pinning TG develop pre-releases instead of the latest stable. Fixed on develop in 05098dc. Use workflow_dispatch with channel=prerelease if you want to canary a TG develop build.

@tig tig closed this Aug 22, 2026
@tig
tig deleted the bump/terminal-gui-2.4.18-develop.41 branch August 22, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant