Feature/battery warning msi laptop - #45
Conversation
| } | ||
|
|
||
| // publish voice message | ||
| if (old_message != message && message != "") |
There was a problem hiding this comment.
Good to have indeed :-)
Can also be part of the callback though AFAIK
There was a problem hiding this comment.
I agree. We would want to check whether the percentage has changed rather than the message
|
@PetervDooren can you test this and merge it? |
|
Tested on the robot. After this last commit it works |
MatthijsBurgh
left a comment
MatthijsBurgh
left a comment
There was a problem hiding this comment.
I would like the launch file rename to battery_manager_hero2.launch
MatthijsBurgh
left a comment
MatthijsBurgh
left a comment
There was a problem hiding this comment.
Please test before merging
| ros::param::get("/robot_location", robot_location); | ||
|
|
||
| ros::Subscriber battery_sub = gn.subscribe("battery", 1, batteryCallback); | ||
| speech_pub = gn.advertise<std_msgs::String>("text_to_speech/input", 10); |
There was a problem hiding this comment.
This speech publisher goes to the text to speech bridge node. Please either:
- publish directly to the toyota interface (my preference)
- launch the speech bridge along with the battery manager
There was a problem hiding this comment.
How can I publish directly to the toyota interface? What is the topic name?
There was a problem hiding this comment.
It can be found in the speech bridge https://github.com/tue-robotics/hero_bridge/blob/master/src/speech_node/speech.py
| } | ||
|
|
||
| // publish voice message | ||
| if (old_message != message && message != "") |
There was a problem hiding this comment.
I agree. We would want to check whether the percentage has changed rather than the message
|
@KevinDang74 Installation process on hero2 is taken care of. I still have some changes I would like to see so I'm passing it back to you |
MatthijsBurgh
left a comment
MatthijsBurgh
left a comment
There was a problem hiding this comment.
I think this should be in this package. As it is only used on the robot and not in simulation
1b3ad51 to
d807f5f
Compare
4 participants
No description provided.