Skip to content

fix: 🐛 support for new zip urls #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ttskch merged 1 commit into from
May 11, 2026
+6 −6
Merged

fix: 🐛 support for new zip urls #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/DataSource/ZipUrls.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

final readonly class ZipUrls
{
public const string KEN_ALL = 'https://www.post.japanpost.jp/zipcode/dl/kogaki/zip/ken_all.zip';
public const string KEN_ALL_ROME = 'https://www.post.japanpost.jp/zipcode/dl/roman/KEN_ALL_ROME.zip';
public const string JIGYOSYO = 'https://www.post.japanpost.jp/zipcode/dl/jigyosyo/zip/jigyosyo.zip';
public const string KEN_ALL = 'https://www.post.japanpost.jp/service/search/zipcode/download/kogaki/zip/ken_all.zip';
public const string KEN_ALL_ROME = 'https://www.post.japanpost.jp/service/search/zipcode/download/roman/KEN_ALL_ROME.zip';
public const string JIGYOSYO = 'https://www.post.japanpost.jp/service/search/zipcode/download/office/zip/jigyosyo.zip';
}
6 changes: 3 additions & 3 deletions tests/Command/BuildCommandTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ class BuildCommandTest extends TestCase
public function testExecute(): void
{
$csvProvider = $this->prophesize(CsvProviderInterface::class);
$csvProvider->fromZipUrl('https://www.post.japanpost.jp/zipcode/dl/kogaki/zip/ken_all.zip')->willReturn(Reader::createFromString('ken,all,csv'));
$csvProvider->fromZipUrl('https://www.post.japanpost.jp/zipcode/dl/roman/KEN_ALL_ROME.zip')->willReturn(Reader::createFromString('kenall,rome,csv'));
$csvProvider->fromZipUrl('https://www.post.japanpost.jp/zipcode/dl/jigyosyo/zip/jigyosyo.zip')->willReturn(Reader::createFromString('jigyo,syo,csv'));
$csvProvider->fromZipUrl('https://www.post.japanpost.jp/service/search/zipcode/download/kogaki/zip/ken_all.zip')->willReturn(Reader::createFromString('ken,all,csv'));
$csvProvider->fromZipUrl('https://www.post.japanpost.jp/service/search/zipcode/download/roman/KEN_ALL_ROME.zip')->willReturn(Reader::createFromString('kenall,rome,csv'));
$csvProvider->fromZipUrl('https://www.post.japanpost.jp/service/search/zipcode/download/office/zip/jigyosyo.zip')->willReturn(Reader::createFromString('jigyo,syo,csv'));

$kenAllCsvParser = $this->prophesize(CsvParserInterface::class);
$kenAllCsvParser->parse(['ken', 'all', 'csv'])->willReturn(new ParsedCsvRow(
Expand Down
Loading