change: redis connection pool → Conection Managerへ#71
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 43db325f56
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ttatsato
changed the title
|
@codex review it |
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary / 概要
Refactor Valkey-based components to hold a shared
MultiplexedConnectioninstead of creating a new Redis client connection for each operation.ValkeyAuthCacheandValkeyRateLimiternow establish a multiplexed connection at initialization, reuse cloned connections for Redis commands (including the startup health check), and avoid repeated connection setup during normal request handling.Background / 背景 *
We previously created a new Redis multiplexed connection from the client for each cache or rate-limiting operation.
This added unnecessary connection setup overhead and made it harder to reason about how many active connections the service was holding.
To simplify connection management and improve efficiency, we want Valkey-based components to reuse a shared multiplexed connection that is established once initialization
Issue (or Discussion) Link / イシューまたはディスカッションのリンク
Impact / 影響範囲
-- 既存のDBスキーマに影響があるなど
Changes / 変更内容
Testing / テスト*
cargo fmt && cargo clippypass with no warningsChecklist / セルフチェックリスト
Screenshots or Video / スクリーンショット・動画
Notes / 備考