add local-expires#35
Open
limomx wants to merge 6 commits into
Open
Conversation
You can set localstorage expiration time, defaults to 10 years
|
|
||
| describe('Lockr.set', function () { | ||
| it('saves a key-value pair in the localStorage', function () { | ||
| describe('Lockr.set', function() { |
Owner
There was a problem hiding this comment.
@lamentchina please add a functional test using set and expire-time argument.
Author
There was a problem hiding this comment.
thanks, I will add a test after "describe 'with pre-existing data' "
Owner
|
Wow great work! What happens when expiration time is up? Should we remove the object entirely from |
add the test for expiration time
merge tsironis/master
Owner
|
@eavgerinos can you do an additional code review so we merge it to master? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can set localstorage expiration time, defaults to 10 years.