Package the eecircuit runtime with the ngspice engine - #28
Open
ShiboSoftwareDev wants to merge 1 commit into
Open
Package the eecircuit runtime with the ngspice engine#28ShiboSoftwareDev wants to merge 1 commit into
ShiboSoftwareDev wants to merge 1 commit into
Conversation
ShiboSoftwareDev
marked this pull request as ready for review
July 30, 2026 16:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
@tscircuit/eecircuit-engine1.7.6 as a runtime dependencyWhy
The ngspice engine previously needed network access on first use and evaluated the downloaded module through a Blob URL. Packaging the engine makes simulations deterministic and available in Node without a runtime CDN request. The eecircuit package already embeds its WASM binary.
Validation
bun test— 44 passbun run typecheckbun run buildbun run format:checkbun run lint