feat: add UTDFN-4-EP footprint alias#640
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aeffaeed3e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return def | ||
| .trim() | ||
| .replace( | ||
| /^(?:utdfn|udfn)-?(\d+)-ep\((\d+(?:\.\d+)?)x(\d+(?:\.\d+)?)(?:mm)?\)$/i, |
There was a problem hiding this comment.
The new normalization regex only matches when the entire string is exactly UTDFN/UDFN-…-EP(...) because it is anchored with $, so aliases stop working as soon as standard underscore options are appended (for example UTDFN-4-EP(1x1)_norefdes or _nosilkscreen). In those cases normalization is skipped, utdfn is treated as the footprint function, and downstream calls fail with an invalid footprint function error. Existing aliases in this file use (?=_|$) specifically to preserve these suffix options, so this new alias should follow the same pattern.
Useful? React with 👍 / 👎.
1 participant
Refs #183.
Summary:
Validation: