Skip to content

Analyze supplier part orientation during render - #2998

Merged
seveibar merged 4 commits into
mainfrom
feat/part-orientation-analysis
Aug 3, 2026
Merged

Analyze supplier part orientation during render#2998
seveibar merged 4 commits into
mainfrom
feat/part-orientation-analysis

Conversation

@seveibar

@seveibar seveibar commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add an opt-in PartOrientationAnalysis render phase gated by platformConfig.enablePartOrientationAnalysis
  • infer each component's authored, unrotated pin1_location, preserving an explicit Footprinter pin1location(...) declaration when present
  • fetch supplier footprints through the configured PartsEngine and attach supplier_pin1_location_map metadata to pcb_component
  • cache supplier analysis through localCacheEngine and deduplicate concurrent requests per PartsEngine
  • correctly invert placed rotation and bottom-layer reflection before analyzing local footprint geometry
  • use @tscircuit/circuit-json-util for canonical semantic pin 1 inference; no numeric rotation offsets or warning elements are introduced

Testing

  • focused render test covers a rotated bottom-layer component, JLCPCB and PCBWay supplier metadata, persistent cache reuse, and a PCB snapshot
  • bun test tests/components/normal-components/part-orientation-analysis.test.tsx
  • bunx tsc --noEmit
  • bun run build
  • Biome check on changed files

Dependencies

@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tscircuit-core-benchmarks Ready Ready Preview Aug 3, 2026 8:00pm

Request Review

@seveibar
seveibar merged commit 8ab8da4 into main Aug 3, 2026
11 checks passed
@seveibar
seveibar deleted the feat/part-orientation-analysis branch August 3, 2026 20:09
@tscircuitbot

Copy link
Copy Markdown
Contributor

Thank you for your contribution! 🎉

PR Rating: ⭐⭐⭐
Impact: Major

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants