Serialize keepout excludeRefs as PCB component IDs - #2958
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Aug 1, 2026
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
excludeRefskeepout prop from@tscircuit/props.ANT1within the keepout's subcircuitexcluded_pcb_component_idson thepcb_keepoutCircuit JSON elementPackage responsibilities
Core only resolves TSX selectors and emits stable Circuit JSON IDs. It does not inspect or filter DRC output. The actual keepout exemption is implemented in
@tscircuit/checks.Released dependencies
circuit-json@^0.0.457, released from Add resolved component exclusions to PCB keepouts circuit-json#670@tscircuit/checks@0.0.147, released from Respect PCB keepout component exclusions checks#176Behavior
The resulting keepout contains ANT1's resolved PCB component ID. Autorouters still receive a hard obstacle with an empty
connectedTolist. Manually routed traces connected to ANT1 do not produce that keepout-overlap error, while unrelated violations remain visible.Validation
bunx tsc --noEmitbun run build