Skip to content

Fix breakout point SRJ construction to route through boundary points#2360

Open
MustafaMulla29 wants to merge 1 commit into
mainfrom
fix/srj
Open

Fix breakout point SRJ construction to route through boundary points#2360
MustafaMulla29 wants to merge 1 commit into
mainfrom
fix/srj

Conversation

@MustafaMulla29
Copy link
Copy Markdown
Contributor

@MustafaMulla29 MustafaMulla29 commented May 30, 2026

  • Filter directTraceConnections by subcircuit_id so internal traces routed inside a breakout are not duplicated in the parent's SRJ
  • Add breakout point coordinates as additional points in pointsToConnect for cross-boundary traces, ensuring the autorouter routes through the boundary crossing
  • Skip breakout points that are already handled by cross-boundary traces; only create direct [port, bp] connections for manual breakout points without a cross-boundary trace

@vercel
Copy link
Copy Markdown

vercel Bot commented May 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tscircuit-core-benchmarks Ready Ready Preview, Comment May 30, 2026 2:46pm

Request Review

@MustafaMulla29
Copy link
Copy Markdown
Contributor Author

@seveibar tried to solve it by following your suggestions, but i think there are still issues.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it creates 2 traces for VCC connection but one stops at breakoutpoint at top

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here as well, extra trace to the breakout point, instead of going through it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks quite good

@MustafaMulla29 MustafaMulla29 requested a review from seveibar May 30, 2026 14:54
Copy link
Copy Markdown
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think this is correct, breakout points should be used but their matched point should be excluded, this will fix traces not using the breakout point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants