Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
||
| // If solver placed a same-net label near this port (possibly with wrong | ||
| // anchor due to trace routing), fix it in place rather than duplicating | ||
| const sameNetLabelNearPort = db.schematic_net_label.list().find((nl) => { |
There was a problem hiding this comment.
shouldn't this fix be in the solver?
seveibar
changed the title
| const { name: text } = getNetNameFromPorts(portsOnSameNet) | ||
| const side = | ||
| getEnteringEdgeFromDirection( | ||
| (schPort.facing_direction as any) || "right", |
There was a problem hiding this comment.
| (schPort.facing_direction as any) || "right", | |
| schPort.facing_direction || "right", |
There was a problem hiding this comment.
if you need to cast schPort, i think it should be done somewhere else
|
|
||
| db.schematic_net_label.insert({ | ||
| text, | ||
| source_net_id: connKey, |
There was a problem hiding this comment.
a connKey is not a source_net_id, this is a bug
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
connKey is not a source_net_id, otherwise generally ok
|
also see my revised PR title, if you don't write a good PR title the changelog will not have your changes, also your impact score is automatically penalized in our contribution tracker, so it's better to write a good PR title- it is the only text that matters for impact scores |
It does look like its more of a sch trace solver issue. |
|
yea there shouldn't be much or any algorithm stuff in core- it's better suited for dedicated repos |
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
3 participants
No description provided.