Skip to content

Add source diagnostic checks - #4062

Merged
0hmX merged 2 commits into
mainfrom
agent/add-source-diagnostic-checks-v2
Aug 6, 2026
Merged

Add source diagnostic checks#4062
0hmX merged 2 commits into
mainfrom
agent/add-source-diagnostic-checks-v2

Conversation

@0hmX

@0hmX 0hmX commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add the check source subcommand using categorizeErrorOrWarning
  • make plain check print every detected error and warning without category filtering
  • preserve source and unknown diagnostics when existing category ignore flags are used
  • keep existing category-specific commands and mappings unchanged

Behavior

source_property_ignored_warning remains visible through both plain check and check source. Plain check is exhaustive and includes source, netlist, placement, routing, pin-specification, and unknown diagnostic types.

No property-name matching, message parsing, Circuit JSON metadata, schema changes, or diagnostic-producer changes are involved.

Dependency

Uses the published @tscircuit/circuit-json-util@0.0.105 release containing the first-class source category.

Validation

  • 12 focused and existing category tests passed against the published utility package
  • TypeScript type-check passed
  • production build passed
  • formatting and diff checks passed

Supersedes #4042 with a clean branch based directly on current main.

@0hmX
0hmX marked this pull request as ready for review August 6, 2026 09:30
@0hmX
0hmX merged commit 6f9d86a into main Aug 6, 2026
10 checks passed
@0hmX
0hmX deleted the agent/add-source-diagnostic-checks-v2 branch August 6, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants