Follow insertion_direction rename to top/bottom - #179
Merged
seveibar merged 1 commit intoAug 3, 2026
Conversation
addibble
force-pushed
the
feat/insertion-direction-canonical-axes
branch
2 times, most recently
from
August 2, 2026 21:38
83c4b75 to
5d7178e
Compare
Circuit JSON renamed the +/-Y insertion directions from "from_front"/"from_back" to "from_top"/"from_bottom" and added "from_below" (-Z). Update the mapping to match, treating "from_below" like "from_above": neither constrains an in-plane facing direction, so both yield null. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
addibble
force-pushed
the
feat/insertion-direction-canonical-axes
branch
from
August 2, 2026 21:41
5d7178e to
ff5222d
Compare
seveibar
approved these changes
Aug 3, 2026
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Circuit JSON renamed the +/-Y insertion directions from "from_front"/"from_back" to "from_top"/"from_bottom" and added "from_below" (-Z). Update the mapping to match, treating "from_below" like "from_above": neither constrains an in-plane facing direction, so both yield null.