Index weighted connection lookups - #121
Open
imrishabh18 wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
imrishabh18
marked this pull request as ready for review
August 6, 2026 11:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isStrongConnectionandgetStronglyConnectedPadIdsRoot cause
isStrongConnectionpreviously scanned the entireweightedConnectionsarray twice for every pad-pair check: once to find an explicit pair and again to determine whether either pad rejects weak connections.Candidate generation and scoring call this function inside nested component/pad loops. On the captured large board, that repeatedly scanned 670 weighted connections across tens of thousands of candidate evaluations.
Impact
For the same 100,000-step workload in
repro-large-weighted-connections.test.ts:The indexed run preserves the same solver state at the existing limit: 126 components packed and
failed=true. Raising the parent iteration budget remains a separate change.Validation
bun run typecheckbun test— 127 pass, 11 pre-existing skips, 0 failgit diff --check