Cache target mappings and raise packing iteration budget - #120
Open
imrishabh18 wants to merge 4 commits into
Open
Cache target mappings and raise packing iteration budget#120imrishabh18 wants to merge 4 commits into
imrishabh18 wants to merge 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
imrishabh18
marked this pull request as ready for review
August 6, 2026 10:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SingleComponentPackSolverPackSolver2's iteration budget from 100,000 to 500,000Why
Each
OutlineSegmentCandidatePointSolverpreviously rebuilt the same mapping from the component's pads to already-packed target pads. That mapping depends on the component, its rotation, and the fixed set of packed components—not the outline segment—so viable segments repeated expensive pad and weighted-connection scans.The large repro also could not finish under the inherited 100,000-step limit.
PackSolver2counts nested candidate and optimizer work against its parent budget, and the captured 218-component board needs about 246,892 parent steps. The increased limit gives large valid boards enough room to complete.Impact
mainto 30.22s with the cache.Validation
bun run typecheckbun test tests/network-target-mapping-cache.test.ts tests/outline-candidate-fit-rejection.test.ts tests/PackSolver2.test.ts tests/PackSolver2_01.test.ts— 7 pass, 0 failbun test tests/repros/repro-large-weighted-connections.test.ts— 2 pass, 0 failgit diff --check