Skip to content

Render sharp via and plated-hole pads at every zoom level - #962

Draft
imrishabh18 wants to merge 3 commits into
mainfrom
agent/sharpen-via-copper-textures
Draft

Render sharp via and plated-hole pads at every zoom level#962
imrishabh18 wants to merge 3 commits into
mainfrom
agent/sharpen-via-copper-textures

Conversation

@imrishabh18

@imrishabh18 imrishabh18 commented Aug 5, 2026

Copy link
Copy Markdown
Member

Summary

  • render via annuli as GPU-instanced analytic rings in both JSCAD and Manifold previews
  • remove rasterized via and plated-hole pads from the combined board texture so the sharp preview geometry is the only visible copper edge
  • harden antialiased removal-mask pixels to eliminate the residual fuzzy fringe
  • reuse the same layer-aware raster-removal path for vias and all plated-hole pad shapes
  • keep existing plated-hole geometry and board texture resolution unchanged
  • exclude analytic via rings from GLTF exports, so GLTF/STEP and other model output sizes do not grow
  • retain mipmaps and anisotropic filtering for the rest of the board texture

Root cause

The board texture and the sharp copper geometry overlapped. Antialiased edge pixels in the removal mask were only partially erased by destination-out, leaving a blurred/scalloped copper halo under close zoom.

Verification

  • visually verified circular and rectangular/pill plated holes at close zoom in JSCAD and Manifold
  • bun run build
  • new unit coverage for shared via/plated-hole filtering and fully opaque removal-mask edges
  • existing analytic-mesh and export-size safeguard tests pass
  • full bun test: 29 pass; 3 existing failures remain from the unrelated local tscircuit dependency update (faux-board Z expectations and soldermask color expectation)

The unrelated package.json change is not included in this PR.

@vercel

vercel Bot commented Aug 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
3d-viewer Ready Ready Preview Aug 5, 2026 7:35am

Request Review

@imrishabh18 imrishabh18 changed the title Sharpen copper textures at oblique angles Render sharp via pads at every zoom level Aug 5, 2026
@imrishabh18 imrishabh18 changed the title Render sharp via pads at every zoom level Render sharp via and plated-hole pads at every zoom level Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant