Use embedded Manifold browser runtime - #956
Draft
seveibar wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
manifold-3d@3.2.1with@tscircuit/manifold-2d@0.0.4Root cause
CadViewerManifoldinjected a module script that importedmanifold-3dfrom jsDelivr. Runframe bundles 3d-viewer into its standalone preview, andtscircuitcopies that standalone bundle, so the publishedtscircuitbrowser artifact still contained a livemanifold-3druntime dependency even after its npm dependency graph was cleaned.Browser regression
The new test bundles the same loader used by the viewer for the browser, asserts the bundle contains no
manifold-3dreference, launches headless Chromium, initializes the embedded WASM payload, creates a cube, and verifies geometry was produced.Verification
bun run test:browser-manifold— passed in Chromiumbun run buildbun run test:node-bundlebunx tsc --noEmitbun run format:checkgit diff --checkdist/index.jshas nomanifold-3dor jsDelivr Manifold reference