Fix WebGL context leak on Canvas unmount - #939
Open
Msa360 wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
seveibar
approved these changes
Jun 25, 2026
Contributor
There was a problem hiding this comment.
let's get a second reviewer to make sure that this works, i'm not seeing a lot of stuff about this method online CC @Abse2001 @ShiboSoftwareDev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main viewer's unmount cleanup called
renderer.dispose()but neverrenderer.forceContextLoss(), so each tab switch stranded a WebGL context until the browser hit its ~16-context limit and evicted the oldest.dispose()only frees GPU resources;forceContextLoss()releases the context itself.OrientationCubeCanvasalready did this correctly.