Skip to content

Normalize OBJ loader cache keys - #938

Open
yanziwei wants to merge 1 commit into
tscircuit:mainfrom
yanziwei:yanziwei/normalize-obj-cache-key
Open

Normalize OBJ loader cache keys#938
yanziwei wants to merge 1 commit into
tscircuit:mainfrom
yanziwei:yanziwei/normalize-obj-cache-key

Conversation

@yanziwei

@yanziwei yanziwei commented Jun 8, 2026

Copy link
Copy Markdown

Summary

/claim #93

  • Normalizes the shared OBJ/WRL loader cache key by removing only cachebust_origin.
  • Preserves the original cleaned URL for fetching/parsing and keeps meaningful query/hash data in the cache key.
  • Evicts failed cache entries so transient OBJ/WRL load failures can retry on a later mount.

Validation

  • npx biome check src/hooks/use-global-obj-loader.ts
  • npx tsc --noEmit --pretty false
  • npm run build
  • git diff --check

Note: dependencies were already installed locally with npm install --no-package-lock --legacy-peer-deps for validation without changing any lockfile.

@vercel

vercel Bot commented Jun 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
3d-viewer Ready Ready Preview, Comment Jun 8, 2026 10:05am

Request Review

@MikeGarciaAGM MikeGarciaAGM left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Normalizing the OBJ cache key around cachebust_origin is a precise fix, and the cache invalidation behavior on error is improved as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants