fix: cache load3DModel by normalized URL - #932
Open
MikeGarciaAGM wants to merge 3 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
Proof / verification:
What the tests prove:
That directly covers the lag source from repeated cache-busted model loads while keeping each scene instance isolated. |
Author
|
Follow-up fix pushed after review feedback: moved normalization to global OBJ loader path (use-global-obj-loader.ts), added global-obj-loader-cache-key tests, and re-ran build/tests on latest head 9a36200. Please re-review when you have a moment. Thanks. |
Author
|
Type-check/CI follow-up pushed for the failing checks. Latest head: Verification run locally:
The patch only guards the normalized extension path against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #93
Summary
load3DModel, removingcachebust_origin, sorting query params, and dropping hash fragments.Validation
npx bun test tests/load-model-cache-key.test.tsnpm run build