Fix GLTF model lifecycle cleanup - #926
Open
DYSfu wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MikeGarciaAGM
approved these changes
Jun 9, 2026
MikeGarciaAGM
left a comment
There was a problem hiding this comment.
Looks good. Cleaning up GLTF lifecycle resources is the right fix here, and the test coverage matches the intended disposal behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #93
Summary
gltfUrlchanges, so translucent-state toggles no longer start anotherGLTFLoaderrequest.Object3Dresource disposer for owned geometries, materials, and material textures, with coverage that shared environment maps are left intact.Validation
bun test tests/dispose-object3d-resources.test.tsbunx biome check src/utils/dispose-object3d-resources.ts src/three-components/GltfModel.tsx tests/dispose-object3d-resources.test.tsbunx tsc --noEmit --pretty falsebun run buildgit diff --check