Fix cached STEP blob URL reuse - #922
Open
silktravelsadmin wants to merge 2 commits into
Open
Conversation
Reuse the in-memory STEP conversion before rebuilding a blob URL from localStorage.
Cover reuse of completed STEP conversions before reading persistent cache again.
silktravelsadmin
requested review from
Abse2001 and
ShiboSoftwareDev
as code owners
May 22, 2026 21:57
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Quick status check on this one: the scoped STEP cache fix is still open/mergeable, Vercel is green, and the Algora claim is still pending. Happy to adjust the approach if you want this handled differently before merge. |
|
Follow-up status: this PR is still open/mergeable, and the current head has Type Check, Format Check, Test Node Bundle Load, and Vercel all passing. The Algora claim page is still showing Total paid Happy to make any final adjustments needed for merge. |
MikeGarciaAGM
approved these changes
Jun 9, 2026
MikeGarciaAGM
left a comment
MikeGarciaAGM
left a comment
There was a problem hiding this comment.
Looks good. Extracting the STEP cache path into a reusable helper is a tidy improvement, and the tests cover the cache reuse behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
bun test tests/step-model-cache.test.tsbunx tsc --noEmitbunx biome format src/three-components/StepModel.tsx tests/step-model-cache.test.tsbun run buildNote:
bun teststill has existing failures inoutline-bounds.test.tsandpreprocess-circuit-json.test.tsthat are unrelated to this STEP cache change./claim #93
AI-assisted with Codex; I reviewed the patch and verification results.