Dispose Error3d fallback mesh resources - #918
Open
cuongwf1711 wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cuongwf1711
force-pushed
the
fix-93-dispose-error3d-fallback
branch
from
May 22, 2026 01:21
3aecb50 to
d323c7e
Compare
Author
|
Quick follow-up for maintainers: this PR is still mergeable and all checks/previews are green. Please let me know if you want any changes for the bounty claim. |
Author
|
Quick status bump: this bounty PR still has all checks green and no unresolved review feedback. Could a maintainer take a look when available, or let me know if this should be updated/rebased? |
MikeGarciaAGM
approved these changes
Jun 9, 2026
MikeGarciaAGM
left a comment
MikeGarciaAGM
left a comment
There was a problem hiding this comment.
Looks good. Disposing fallback mesh resources closes a straightforward leak path, and the tests verify the cleanup behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #93
Summary
disposeMeshResourceshelper for mesh geometry and material cleanupError3dfallback box mesh resources when it unmountsVerification
All verification was run inside Docker on a copied workspace:
bun test tests/dispose-mesh-resources.test.tsbunx tsc --noEmitbun run format:checkbun run build