fix: ignore cachebust_origin in obj loader cache key - #916
Open
LaoChouPro wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MikeGarciaAGM
approved these changes
Jun 9, 2026
MikeGarciaAGM
left a comment
MikeGarciaAGM
left a comment
There was a problem hiding this comment.
Looks good. Globalizing the OBJ loader cache is a good deduplication move, and the cache-key tests are precise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes duplicate OBJ/WRL model cache misses when otherwise identical model URLs include different cachebust_origin values.
The fetch URL is preserved, but the cache key is normalized by removing cachebust_origin. This lets repeated models share the same in-flight promise or parsed result instead of fetching and parsing again.
Verification:
Note: npx bun test currently has unrelated baseline failures in outline-bounds and preprocess-circuit-json; I verified the same failures on HEAD~1.
/claim #93