Fix r2 for 4.0.0#265
Conversation
|
| Filename | Overview |
|---|---|
| compose.yaml | Four targeted fixes for 4.0.0: adds RR_GIT_SERVER to api SERVICE_TYPE, corrects js-executor mem_limit from 4g to 2g, removes obsolete EXECUTOR_IMAGE env var from agent-sandbox-controller, and exposes MinIO to the agent-sandbox network with the retool-rr-snapshots.minio alias. |
| install.sh | Removes an outdated comment about the 3.391.0+ version requirement for blob storage vars; no logic changes. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
subgraph backend["backend network"]
api["api\n(MAIN_BACKEND, DB_CONNECTOR,\nDB_SSH_CONNECTOR, RR_GIT_SERVER)"]
minio["minio\naliases: retool-blob-storage.minio\n retool-rr-git.minio\n retool-rr-snapshots.minio"]
postgres["postgres"]
asc["agent-sandbox-controller\n(no EXECUTOR_IMAGE)"]
asp["agent-sandbox-proxy"]
end
subgraph agent_sandbox["agent-sandbox network"]
asc
asp
r2["r2-agent-worker"]
minio_as["minio\nalias: retool-rr-snapshots.minio NEW"]
end
subgraph js_exec["js-executor network"]
jse["js-executor\nmem_limit: 2g FIXED"]
end
api -->|"reads snapshots"| minio_as
r2 -->|"retool-rr-snapshots.minio"| minio_as
minio -- "same instance" --- minio_as
Reviews (1): Last reviewed commit: "comments" | Re-trigger Greptile
| agent-sandbox: | ||
| aliases: | ||
| - retool-rr-snapshots.minio |
There was a problem hiding this comment.
Partial alias coverage for agent-sandbox network
Only retool-rr-snapshots.minio is aliased into the agent-sandbox network. If R2 agent sandbox containers (or workloads they spawn) also need to reach retool-rr-git.minio or retool-blob-storage.minio — for example, to read git-backed apps or general blob storage — those hostnames will be unresolvable from within that network, causing connection failures. Consider whether the other two aliases used in the backend network should also be exposed here.
Some changes with 4.0.0-stable broke this. This pr fixes that.