Skip to content

Fix r2 for 4.0.0#265

Open
lukefoster11 wants to merge 4 commits into
r2from
lfoster/fix-r2
Open

Fix r2 for 4.0.0#265
lukefoster11 wants to merge 4 commits into
r2from
lfoster/fix-r2

Conversation

@lukefoster11

Copy link
Copy Markdown

Some changes with 4.0.0-stable broke this. This pr fixes that.

@greptile-apps

greptile-apps Bot commented Jun 15, 2026

Copy link
Copy Markdown

Greptile Summary

This PR applies a set of targeted fixes to the r2 branch so that the Docker Compose stack works correctly with the 4.0.0-stable release.

  • Adds RR_GIT_SERVER to the api service's SERVICE_TYPE, corrects the js-executor memory limit from 4g to 2g (aligning it with the 2048 MiB helm chart default stated in the adjacent comment), removes the now-obsolete EXECUTOR_IMAGE env var from agent-sandbox-controller, and exposes MinIO to the agent-sandbox network with the retool-rr-snapshots.minio alias so R2 agent workloads can reach snapshot storage.
  • install.sh drops a stale version-requirement comment that was no longer accurate for the 4.0.0 baseline.

Confidence Score: 4/5

Safe to merge; all changes are straightforward configuration corrections with no logic regressions.

The four compose changes are well-scoped: the mem_limit correction aligns the value with the existing comment, RR_GIT_SERVER is a service-type addition, EXECUTOR_IMAGE removal cleans up a variable that 4.0.0 no longer needs, and the MinIO alias addition is the core functional fix. One open question is whether the other two MinIO hostnames (retool-rr-git.minio and retool-blob-storage.minio) also need to be aliased into the agent-sandbox network — if agent workloads reach for those and they're absent, requests will silently fail at DNS resolution.

compose.yaml — specifically the minio agent-sandbox alias block (lines 228–230) and the EXECUTOR_IMAGE removal (line 154).

Important Files Changed

Filename Overview
compose.yaml Four targeted fixes for 4.0.0: adds RR_GIT_SERVER to api SERVICE_TYPE, corrects js-executor mem_limit from 4g to 2g, removes obsolete EXECUTOR_IMAGE env var from agent-sandbox-controller, and exposes MinIO to the agent-sandbox network with the retool-rr-snapshots.minio alias.
install.sh Removes an outdated comment about the 3.391.0+ version requirement for blob storage vars; no logic changes.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    subgraph backend["backend network"]
        api["api\n(MAIN_BACKEND, DB_CONNECTOR,\nDB_SSH_CONNECTOR, RR_GIT_SERVER)"]
        minio["minio\naliases: retool-blob-storage.minio\n          retool-rr-git.minio\n          retool-rr-snapshots.minio"]
        postgres["postgres"]
        asc["agent-sandbox-controller\n(no EXECUTOR_IMAGE)"]
        asp["agent-sandbox-proxy"]
    end

    subgraph agent_sandbox["agent-sandbox network"]
        asc
        asp
        r2["r2-agent-worker"]
        minio_as["minio\nalias: retool-rr-snapshots.minio NEW"]
    end

    subgraph js_exec["js-executor network"]
        jse["js-executor\nmem_limit: 2g FIXED"]
    end

    api -->|"reads snapshots"| minio_as
    r2 -->|"retool-rr-snapshots.minio"| minio_as
    minio -- "same instance" --- minio_as
Loading

Reviews (1): Last reviewed commit: "comments" | Re-trigger Greptile

Comment thread compose.yaml
Comment on lines +228 to +230
agent-sandbox:
aliases:
- retool-rr-snapshots.minio

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Partial alias coverage for agent-sandbox network

Only retool-rr-snapshots.minio is aliased into the agent-sandbox network. If R2 agent sandbox containers (or workloads they spawn) also need to reach retool-rr-git.minio or retool-blob-storage.minio — for example, to read git-backed apps or general blob storage — those hostnames will be unresolvable from within that network, causing connection failures. Consider whether the other two aliases used in the backend network should also be exposed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant