Generalize attention Q/KV modes#582
Merged
Merged
Conversation
CC-Yeh
force-pushed
the
generalize_attention
branch
from
ff8666f to
ef037d6
Compare
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
uuuvn
requested changes
Jul 6, 2026
| utils::maybe_mut::MaybeMut, | ||
| }; | ||
|
|
||
| pub(super) type AttentionPrepare<B> = <<B as Backend>::Kernels as Kernels>::AttentionPrepareKernel; |
Contributor
There was a problem hiding this comment.
This obscures what AttentionPrepare is by making it look like a block where in fact it is a kernel
Contributor
Author
There was a problem hiding this comment.
Replaced it with PrepareKernel
CC-Yeh
force-pushed
the
generalize_attention
branch
from
be91bf4 to
1d3b275
Compare
uuuvn
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.