fix: handle null firstName/lastName in setConnectedTo (#3)#40
Merged
Conversation
* fix: handle null firstName/lastName in setConnectedTo The TryFi API can return null for firstName or lastName on the user a collar is connected to (e.g. when the account email is stored as firstName with lastName=null). The previous code used string concatenation which raised TypeError: can only concatenate str (not NoneType) to str, causing the integration to fail setup. Use .get() with empty string fallback and f-string interpolation instead of raw concatenation. * test: add unit tests for FiDevice.setConnectedTo Tests cover all connection state types: - ConnectedToUser with both names present - ConnectedToUser with null lastName (the bug that caused TypeError) - ConnectedToUser with null firstName - ConnectedToUser with both names null - ConnectedToUser with missing name keys entirely - ConnectedToCellular with signal strength - ConnectedToBase with base ID - Unknown connection type returning None --------- Co-authored-by: prestomation <dev@prestomation.local>
ajacques
approved these changes
Jun 27, 2026
Contributor
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TryFi API can return null for firstName or lastName on the user a collar is connected to (e.g. when the account email is stored as firstName with lastName=null). The previous code used string concatenation which raised TypeError: can only concatenate str (not NoneType) to str, causing the integration to fail setup.
Use .get() with empty string fallback and f-string interpolation instead of raw concatenation.
Tests cover all connection state types: