Bump ignition version#288
Merged
SpaceFace02 merged 2 commits intoJun 23, 2026
Merged
Conversation
- Switch ignition_config from v3_5 to v3_6, removing the manual version overwrite workaround for 3.6.0-experimental. - Bump fedora-coreos-kubevirt test image to 42.20260622, with ignition version 2.26.0, so that it can parse ignition spec version 3.6.0. - Updated documentation accordingly. Signed-off-by: Chirag Rao <crao@redhat.com>
…w CRD. Signed-off-by: Chirag Rao <crao@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpgrades the project to Ignition spec v3.6.0 and a newer Fedora CoreOS kubevirt test image, removes the temporary Ignition version override workaround, and hardens the operator so images are not processed for clusters being deleted, with docs and example manifests updated accordingly. Flow diagram for updated image_add_reconcile deletion handlingflowchart TD
A[image_add_reconcile called for image] --> B[Find TrustedExecutionCluster]
B -->|Not found| C[Return Action::requeue 5s]
B -->|Found cluster| D[Check cluster.metadata.deletion_timestamp]
D -->|Some| E[Return Action::requeue 5s]
D -->|None| F[Check image owner_references with uid_owns]
F --> G[Continue image processing]
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Jakob-Naucke
approved these changes
Jun 23, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Jakob-Naucke, SpaceFace02 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
4aa368b
into
trusted-execution-clusters:main
9 of 10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
version overwrite workaround for 3.6.0-experimental.
Summary by Sourcery
Upgrade ignition configuration version and related test image, and ensure images are not reconciled for clusters being deleted.
Bug Fixes:
Enhancements:
Build:
Documentation:
Tests: