Skip to content

Bump ignition version#288

Merged
SpaceFace02 merged 2 commits into
trusted-execution-clusters:mainfrom
SpaceFace02:bump-ignition-version
Jun 23, 2026
Merged

Bump ignition version#288
SpaceFace02 merged 2 commits into
trusted-execution-clusters:mainfrom
SpaceFace02:bump-ignition-version

Conversation

@SpaceFace02

@SpaceFace02 SpaceFace02 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor
  1. Test Enhancement: Cluster marked for deletion should never own any new CRD.
  2. Upgrade to Ignition v3.6.0 stable and bump FCOS test image
    • Switch ignition_config from v3_5 to v3_6, removing the manual
      version overwrite workaround for 3.6.0-experimental.
    • Bump fedora-coreos-kubevirt test image to 42.20260622, with ignition version 2.26.0, so that it can parse ignition spec version 3.6.0.
    • Updated documentation accordingly.

Summary by Sourcery

Upgrade ignition configuration version and related test image, and ensure images are not reconciled for clusters being deleted.

Bug Fixes:

  • Prevent image reconciliation from assigning ownership to clusters that are marked for deletion.

Enhancements:

  • Adopt ignition_config v3.6 with stable 3.6.0 spec handling and remove the previous experimental version override workaround.

Build:

  • Update the Fedora CoreOS KubeVirt test image reference to version 42.20260622.

Documentation:

  • Refresh ignition-related documentation and example manifests to reference spec version 3.6.0 and the new test image tag.

Tests:

  • Align test ignition generation with v3.6.0 spec and the updated CoreOS test image.

- Switch ignition_config from v3_5 to v3_6, removing the manual
  version overwrite workaround for 3.6.0-experimental.
- Bump fedora-coreos-kubevirt test image to 42.20260622, with ignition version 2.26.0, so that it can parse ignition spec version 3.6.0.
- Updated documentation accordingly.

Signed-off-by: Chirag Rao <crao@redhat.com>
…w CRD.

Signed-off-by: Chirag Rao <crao@redhat.com>
@sourcery-ai

sourcery-ai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Upgrades the project to Ignition spec v3.6.0 and a newer Fedora CoreOS kubevirt test image, removes the temporary Ignition version override workaround, and hardens the operator so images are not processed for clusters being deleted, with docs and example manifests updated accordingly.

Flow diagram for updated image_add_reconcile deletion handling

flowchart TD
    A[image_add_reconcile called for image] --> B[Find TrustedExecutionCluster]
    B -->|Not found| C[Return Action::requeue 5s]
    B -->|Found cluster| D[Check cluster.metadata.deletion_timestamp]
    D -->|Some| E[Return Action::requeue 5s]
    D -->|None| F[Check image owner_references with uid_owns]
    F --> G[Continue image processing]
Loading

File-Level Changes

Change Details Files
Remove manual Ignition version override in the registration server now that Ignition v3.6.0 is used directly.
  • Serialize the generated Ignition config directly to JSON without mutating the ignition.version field.
  • Delete the code that overwrote the ignition object with version 3.6.0-experimental.
register-server/src/main.rs
Prevent image reconciliation when the owning TrustedExecutionCluster is being deleted.
  • Add a deletionTimestamp check on the fetched TrustedExecutionCluster and early-return with a short requeue delay when set.
  • Log a specific message indicating that image processing is deferred because the cluster is being deleted.
operator/src/reference_values.rs
Switch tests and examples to Ignition config v3.6.0 and update the Fedora CoreOS kubevirt test image.
  • Change test-side Ignition config generation from ignition_config::v3_5 to ignition_config::v3_6.
  • Update the Ignition version string in test ignition config from 3.6.0-experimental to 3.6.0.
  • Bump the default TEST_IMAGE Fedora CoreOS kubevirt image tag to 42.20260622 in the Makefile.
  • Update example manifests to use the new Fedora CoreOS kubevirt image tag.
  • Adjust docs and example Ignition JSON to show Ignition version 3.6.0 instead of 3.5.0.
test_utils/src/virt/mod.rs
Makefile
docs/design/boot-attestation.md
examples/vm-coreos-ign.yaml
examples/ignition-coreos.json

Possibly linked issues

  • #Use ignition 3.6: PR implements the issue’s request by using stable ignition 3.6.0 and updating the FCOS test image.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Jakob-Naucke Jakob-Naucke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

Comment thread operator/src/reference_values.rs
Comment thread operator/src/reference_values.rs
@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jakob-Naucke, SpaceFace02

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SpaceFace02 SpaceFace02 merged commit 4aa368b into trusted-execution-clusters:main Jun 23, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants