-
Notifications
You must be signed in to change notification settings - Fork 10
Gear for OpenShift CI #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jakob-Naucke
wants to merge
14
commits into
trusted-execution-clusters:main
Choose a base branch
from
Jakob-Naucke:openshift-ci
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b096dea
make: Do not track Kind Azure host
Jakob-Naucke 3e1608e
Revert "ci: Avoid cargo for retrieving kopium version"
Jakob-Naucke c46fc90
Fix `v` in image tag version
Jakob-Naucke 160eff3
tests: Fix a missing platform kubectl usage
Jakob-Naucke c08d8af
tests: Use await_condition instead of polling
Jakob-Naucke c4bbd80
tests: Move kubectl() out of K8sPlatform
Jakob-Naucke 07e2b6a
tests: Make client & ns part of K8sPlatform
Jakob-Naucke efaf8b7
tests: Expose OpenShift services with LB services
Jakob-Naucke 9b1fd8d
rbac: Fix finalizers for OpenShift
Jakob-Naucke b2c559a
make: ?= OPERATOR_IMAGE
Jakob-Naucke 08e0a84
tests/azure: Pass Ignition as user-data
Jakob-Naucke 2cf06f8
Requeue upon failed component installation
Jakob-Naucke 30ef74a
tests: Wait for custom resources to remove
Jakob-Naucke 2296e03
tests: Wait for services
Jakob-Naucke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: The new KOPIUM_VERSION detection adds a hard dependency on
jqand a relatively complexcargo metadataquery.This approach is more robust than grepping
Cargo.toml, but it now relies onjqbeing available everywhere the Makefile runs and on the stability of thecargo metadatalayout. If that’s not guaranteed (e.g., minimal CI images, some dev setups), please either document/enforce thejqrequirement with a clear failure message, or simplify how the version is resolved (e.g., restrict the query scope or move the logic into a small helper script/binary) to reduce fragility.Suggested implementation:
If the Makefile already defines a
JQvariable elsewhere (not visible in the provided snippet), you should remove one of the definitions or consolidate them to avoid redefinition. Otherwise, this change will:jqis missing andKOPIUM_VERSIONis not provided.jqrequirement by explicitly supplyingKOPIUM_VERSIONon the command line or in the environment.