fix(ci): sign in the gated job so it can read the production env secret#31
Merged
Conversation
RULES_SIGNING_KEY_ED25519 is a production-environment secret, but the Sign step
ran in the un-gated build job — environment secrets are only readable by a job
that declares the environment, so the build job saw an empty secret and the first
publish would fail at sign ('secret not set'). Move environment: production onto
the build job (which signs); promote runs after the gated, self-verified build, so
the channel re-point stays behind the required-reviewer approval. (TR-323)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Sign step ran in the un-gated
buildjob, butRULES_SIGNING_KEY_ED25519is a production-environment secret — env secrets are only readable by a job that declares the environment. So the build job would see an empty secret and the first publish fails at sign (secret not set).Fix: move
environment: productiononto thebuildjob (the one that signs). The whole signed publish now waits for the required-reviewer approval before anything is signed/released;promoteruns after the gated, self-verified build, so the channel re-point stays gated without a second approval. Caught while validating the pipeline after the engine merge; the ci-workflow audit lens had been throttled before it could verify this. (TR-323)🤖 Generated with Claude Code