-
Notifications
You must be signed in to change notification settings - Fork 13
docs(merge-queue): add stacked PR support section to Chrome Extension page #598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -46,6 +46,26 @@ | |||||
| * **Tests Passed** - waiting for upstream PRs before merging | ||||||
| * **Merged**, **Failed** - terminal states | ||||||
|
|
||||||
| ### Stacked pull requests | ||||||
|
|
||||||
| When a stack is queued with [`/trunk stack`](using-the-queue/stacked-pull-requests.md#merge-the-stack-as-one-unit), the extension shows a stack-aware view on every member PR page. | ||||||
|
|
||||||
| **What the panel shows:** | ||||||
|
|
||||||
| * **Stack path** — the full list of PRs in the stack from tip to base, so you can see where your PR sits within the group. | ||||||
| * **Speculative PR chip** — a link to the combined test PR Trunk created for the stack (labeled **Stacked PR #N**). Click it to open the speculative PR on GitHub and inspect its CI status. | ||||||
|
|
||||||
| **Actions:** | ||||||
|
|
||||||
| * **Add to Merge Queue** — enqueues the entire stack as one unit. Any PR page in the stack triggers the same operation. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Minor — "Any PR page in the stack triggers the same operation" is slightly ambiguous (the page itself doesn't trigger anything; clicking the button does). Consider tightening:
Suggested change
|
||||||
| * **Cancel** — removes the whole stack from the queue. | ||||||
|
|
||||||
| Re-enqueueing after a cancel works the same way: click **Add to Merge Queue** on any member PR page to resubmit the stack. | ||||||
|
|
||||||
| {% hint style="info" %} | ||||||
| Stacked PR queue support requires the [Trunk Sudo GitHub App](../setup-and-administration/trunk-sudo-app.md) and the `/trunk stack` workflow. Stacks submitted one PR at a time with `/trunk merge` are tracked individually, not as a group. | ||||||
| {% endhint %} | ||||||
|
Comment on lines
+65
to
+67
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Suggestion — surface the prerequisite earlier. Readers learn at the very end of the section that the whole flow requires Trunk Sudo and the Consider moving this |
||||||
|
|
||||||
| ### Rolling the Extension out to an entire Org | ||||||
|
|
||||||
| Chrome admins can install the Trunk extension for everyone in a Google Workspace organization using the [Chrome Web Store ID](https://chromewebstore.google.com/detail/liggeliamkammmieidmmfmmdnjilabgn) `liggeliamkammmieidmmfmmdnjilabgn`. See Google's [Automatically install apps and extensions](https://support.google.com/chrome/a/answer/6306504?hl=en) guide for the admin console steps. | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terminology inconsistency. This bullet describes the chip as a "Speculative PR chip" but in the same sentence says it is "labeled Stacked PR #N", and asks readers to click to "open the speculative PR." The companion page
using-the-queue/stacked-pull-requests.mduses stacked PR consistently for this combined PR (the word "speculative" never describes this PR there — it only appears in the predictive-testing context).Recommend renaming the chip and aligning the description with the rest of the docs:
Also note the small tense fix (
Trunk created→Trunk creates) since this describes general behavior rather than a past event.