Skip to content
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions merge-queue/chrome-extension.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,26 @@
* **Tests Passed** - waiting for upstream PRs before merging
* **Merged**, **Failed** - terminal states

### Stacked pull requests

When a stack is queued with [`/trunk stack`](using-the-queue/stacked-pull-requests.md#merge-the-stack-as-one-unit), the extension shows a stack-aware view on every member PR page.

**What the panel shows:**

* **Stack path** — the full list of PRs in the stack from tip to base, so you can see where your PR sits within the group.
* **Speculative PR chip** — a link to the combined test PR Trunk created for the stack (labeled **Stacked PR #N**). Click it to open the speculative PR on GitHub and inspect its CI status.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terminology inconsistency. This bullet describes the chip as a "Speculative PR chip" but in the same sentence says it is "labeled Stacked PR #N", and asks readers to click to "open the speculative PR." The companion page using-the-queue/stacked-pull-requests.md uses stacked PR consistently for this combined PR (the word "speculative" never describes this PR there — it only appears in the predictive-testing context).

Recommend renaming the chip and aligning the description with the rest of the docs:

Suggested change
* **Speculative PR chip** — a link to the combined test PR Trunk created for the stack (labeled **Stacked PR #N**). Click it to open the speculative PR on GitHub and inspect its CI status.
* **Stacked PR chip** — a link to the combined PR Trunk creates for the stack (labeled **Stacked PR #N**). Click it to open the stacked PR on GitHub and inspect its CI status.

Also note the small tense fix (Trunk createdTrunk creates) since this describes general behavior rather than a past event.


**Actions:**

* **Add to Merge Queue** — enqueues the entire stack as one unit. Any PR page in the stack triggers the same operation.

Check failure on line 60 in merge-queue/chrome-extension.md

View workflow job for this annotation

GitHub Actions / Trunk Check

vale(error)

[new] Did you really mean 'enqueues'?
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor — "Any PR page in the stack triggers the same operation" is slightly ambiguous (the page itself doesn't trigger anything; clicking the button does). Consider tightening:

Suggested change
* **Add to Merge Queue** — enqueues the entire stack as one unit. Any PR page in the stack triggers the same operation.
* **Add to Merge Queue** — enqueues the entire stack as one unit. Clicking it on any member PR page submits the same stack.

* **Cancel** — removes the whole stack from the queue.

Re-enqueueing after a cancel works the same way: click **Add to Merge Queue** on any member PR page to resubmit the stack.

{% hint style="info" %}
Stacked PR queue support requires the [Trunk Sudo GitHub App](../setup-and-administration/trunk-sudo-app.md) and the `/trunk stack` workflow. Stacks submitted one PR at a time with `/trunk merge` are tracked individually, not as a group.
{% endhint %}
Comment on lines +65 to +67
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion — surface the prerequisite earlier. Readers learn at the very end of the section that the whole flow requires Trunk Sudo and the /trunk stack workflow. The rest of this page (lines 8–10) follows the convention of placing prerequisite hints at the top so readers don't get partway through before discovering they can't use the feature.

Consider moving this {% hint style="info" %} block to immediately after the ### Stacked pull requests heading, before "What the panel shows."


### Rolling the Extension out to an entire Org

Chrome admins can install the Trunk extension for everyone in a Google Workspace organization using the [Chrome Web Store ID](https://chromewebstore.google.com/detail/liggeliamkammmieidmmfmmdnjilabgn) `liggeliamkammmieidmmfmmdnjilabgn`. See Google's [Automatically install apps and extensions](https://support.google.com/chrome/a/answer/6306504?hl=en) guide for the admin console steps.
Expand Down
Loading