[feature not yet live] - docs(flaky-tests): add Uploads page

[samgutentag]

Summary

• Adds new flaky-tests/uploads-page.md documenting the Uploads page in Trunk Flaky Tests
• Covers the stacked bar chart, multi-filter bar (status, conclusion, PR number, SHA, branch, author), column customizer, upload statuses, and date range selection
• Updates summary.md to include the new page in the sidebar

Source

• trunk2 PR: https://github.com/trunk-io/trunk2/pull/3670

Test plan

• Preview in GitBook

---

Generated by Claude Code

[trunk-staging-io]

Merging to main in this repository is managed by Trunk.

• To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

[claude]

Claude finished @samgutentag's task in 1m 48s —— View job

---

PR Review

• Read CLAUDE.md for repo-specific guidelines
• Review flaky-tests/uploads-page.md
• Review summary.md changes
• Post inline comments for specific issues
• Finalize review

---

Summary

The new flaky-tests/uploads-page.md is well-structured and clearly written. The summary.md addition places the page correctly in the sidebar. No blocking issues found.

Minor issues flagged via inline comments:

1. Line 17 — The word "bins" is unusual in this context; "groups" or "categories" reads more naturally. (view comment)
2. Line 17 — The chart labels ("Pass, Fail, Other") don't obviously map to the upload status names ("Done, Processing, Done (empty), Failed") documented later in the page. A brief explanation of the mapping would help readers. (view comment)
3. Line 38 — Slightly awkward phrasing for clearing the date range selection. (view comment)

All three are non-blocking suggestions.

[github-actions]

Auto-approved: Claude code review passed.

[claude]

Claude finished @samgutentag's task in 1m 39s —— View job

---

PR Review

• Read CLAUDE.md for repo-specific guidelines (no CLAUDE.md found)
• Review flaky-tests/uploads-page.md
• Review summary.md changes
• Post inline comments for specific issues
• Finalize review

---

Summary

The new flaky-tests/uploads-page.md is well-structured and clearly written. The summary.md placement is correct. No blocking issues found.

Non-blocking suggestions (inline comments):

1. Line 17 — "upload bins" is unusual; "groups" or "categories" reads more naturally. (view)
2. Line 17 — The chart labels ("Pass, Fail, Other") don't map obviously to the status table ("Done, Processing, Done (empty), Failed"). A brief note on the mapping would help readers. (view)
3. Line 18 — Minor repetition: "Multiple values can be entered for each filter" is restated on line 23. (view)
4. Line 38 — Slightly awkward phrasing for clearing the date range. (view)

All four are non-blocking suggestions.

[github-actions]

Auto-approved: Claude code review passed.

[samgutentag]

Triage status (2026-05-05): up to date with main. Review approved. Ready to merge.

[samgutentag]

Verification status (2026-05-07): pending (re-run)

Eng merged but flag off in prod. Hold off.

• Eng PR: trunk-io/trunk2#3670 (merged 2026-04-28)
• Flag: enableFilteredUploadsPage
• Signals:
  • Merge commit on main (status: behind, merge intact)
  • Slack 2026-04-16 from Tyler Jang in #eng: "flagged on in staging, off in prod" (this predates the eng PR merge by 12 days but reflects the flag's last known state; no LD activity since)
  • Legacy <UploadsClient> still in main (uploads-client.tsx) alongside the new uploads-filtered-client.tsx
  • No follow-up "delete legacy" or 100% rollout PR found
  • e2e flag default: true (test-only, doesn't affect prod)

PR title already flags "[feature not yet live]". Re-run /verify-docs-pr 589 once prod rollout is confirmed.

[claude]

Claude finished @samgutentag's task in 2m 3s —— View job

---

PR Review

• Read CLAUDE.md for repo-specific guidelines (no CLAUDE.md found)
• Review flaky-tests/uploads-page.md
• Review summary.md changes
• Post inline comments for specific issues
• Finalize review

---

Summary

The new flaky-tests/uploads-page.md is well-organized and the summary.md placement is correct. The page is gated by the enableFilteredUploadsPage flag, which the trigger comment notes is still off in prod — so this is a content-quality review only; no blocking issues for merging once the flag rolls out.

New issues flagged this run (inline comments):

1. Line 27 — Status example list omits Done (empty), creating drift with the status table on lines 50–53. (view)
2. Line 28 — Casing inconsistency between Status row (Done, Processing, Failed) and Conclusion row (success, failure, cancelled). Verify against actual UI labels. (view)
3. Line 32 — Author filter described as "the committer" — Git author and committer can differ. (view)
4. Lines 21–57 — Heading case mismatch: H2 sections are Title Case, the one H3 is sentence case. Other flaky-tests/ pages use sentence case throughout. (view)

Prior feedback still standing (not yet addressed in the file):

• Line 17 — "bins" reads oddly; suggest "groups" or "categories" (view)
• Line 17 — Chart labels (Pass/Fail/Other) don't visibly map to the status table (Done/Processing/Done (empty)/Failed) (view)
• Line 18 — Repeats the "multiple values" wording from line 23 (view)
• Line 38 — Awkward "Click the chart again outside a selection" phrasing (view)

All non-blocking. Safe to merge once the prod flag rolls out and the above are addressed in a follow-up edit pass.
• Branch

[github-actions]

Auto-approved: Claude code review passed.