docs(flaky-tests): document monitor preview panel status filter by samgutentag · Pull Request #587 · trunk-io/docs

samgutentag · 2026-04-28T10:56:01Z

Summary

Adds a Preview Panel section to the failure count monitor page describing the status filter dropdown (Healthy / Flaky / Broken), truncation handling, and how the filter affects the info tooltip.
Adds a Preview Panel section to the failure rate monitor page describing the status filter dropdown, the collapsed-Current default, and how the filter interacts with the Proposed vs Current sections.

Source

trunk2 PR: https://github.com/trunk-io/trunk2/pull/3732

Test plan

Preview in GitBook

Adds a Preview Panel section to both the failure count and failure rate monitor pages describing the new multi-select status filter dropdown (Healthy / Flaky / Broken), truncation handling on the failure count panel, and the collapsed-Current default on the failure rate panel. Source: trunk-io/trunk2#3732 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

trunk-staging-io · 2026-04-28T10:56:05Z

😎 Merged successfully - details.

claude · 2026-04-28T10:56:28Z

Claude finished @samgutentag's task in 1m 28s —— View job

PR Review

Gather context
Read CLAUDE.md for repo guidelines
Review changed files for typos, grammar, and formatting
Post review findings

The documentation additions are clear, well-structured, and accurately describe the preview panel behavior. One minor grammar fix suggested via inline comment.

Findings:

failure-rate-monitor.md line 173 — Missing comma before "so" in a compound sentence. Suggestion posted inline.

Minor observations (non-blocking):

The info tooltip description is slightly inconsistent between the two files: failure-count-monitor.md says "the info tooltip in the panel header shows" while failure-rate-monitor.md just says "the info tooltip shows". Both are clear enough given their respective context.
"not-in-window count" (failure-rate-monitor.md line 183) is a UI-specific label — no change needed unless the UI uses different terminology.

Overall the PR is in good shape. The one inline suggestion is a minor grammar fix and not blocking.

github-actions

Auto-approved: Claude code review passed.

…lter

claude · 2026-05-05T18:34:14Z

Claude finished @samgutentag's task in 53s —— View job

PR Review

Gather context
Read CLAUDE.md for repo guidelines
Review changed files for typos, grammar, and formatting
Post review findings

The documentation additions are clear, well-structured, and accurately describe the preview panel behavior in both monitors. The content is consistent with the existing doc style.

Findings:

failure-rate-monitor.md line 173 — Missing comma before "so" in a compound sentence (same issue flagged in the previous review, still unresolved):

"The Current section is collapsed by default so the Proposed view is immediately visible when you open the form."

Should be: The Current section is collapsed by default, so the Proposed view is immediately visible when you open the form. Fix this →

Minor observations (non-blocking):

Slight phrasing inconsistency between files in the tooltip description: failure-count-monitor.md says "the total that match the monitor configuration" while failure-rate-monitor.md says "the total matching the configuration" — both are clear and readable.
failure-rate-monitor.md line 183: "not-in-window count" is a UI-specific label; no change needed unless the UI uses different terminology.

Overall the PR is in good shape. The one unresolved inline suggestion from the prior review (missing comma) is the only actionable item.

github-actions

Auto-approved: Claude code review passed.

samgutentag · 2026-05-06T03:47:50Z

Triage status (2026-05-05): up to date with main. Review approved. Ready to merge.

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

claude · 2026-05-06T18:14:12Z

Claude finished @samgutentag's task in 1m 14s —— View job

PR Review

Gather context
Read CLAUDE.md for repo guidelines
Review changed files for typos, grammar, and formatting
Post review findings

The previous blocking issue (missing comma on failure-rate-monitor.md:173) has been resolved in commit 9fbb0aa. Both files now read cleanly.

Findings:

No blocking issues. Verified:

failure-rate-monitor.md:173 — comma before "so" is now in place ✓
Heading capitalization (title case) matches the existing style in both files
Em-dash usage is consistent and correct
Grammar and formatting are clean throughout the additions

Minor non-blocking observations (carried over from earlier reviews):

Slight phrasing variance between files in the tooltip description: failure-count-monitor.md says "the total that match the monitor configuration" while failure-rate-monitor.md says "the total matching the configuration" — both read fine.
failure-rate-monitor.md:183 references "not-in-window count" — assumed to match UI terminology; no change needed if so.

LGTM. Ready to merge.
| Branch

github-actions

Auto-approved: Claude code review passed.

…lter

claude · 2026-05-06T22:07:22Z

Claude finished @samgutentag's task in 53s —— View job

PR Review

Gather context
Read CLAUDE.md for repo guidelines
Review changed files for typos, grammar, and formatting
Post review findings

This trigger came from a sync of main into the branch (commit a9258ef); no doc content changed since the prior approving review. The previously flagged blocking issue (missing comma on failure-rate-monitor.md:173) remains resolved.

Findings:

No blocking issues. Verified on the current diff (git diff origin/main...HEAD):

failure-rate-monitor.md:173 — comma before "so" is in place ✓
Heading capitalization (Title Case) is consistent within and across both files
Em-dash usage (—) is consistent and correct
Bold/** emphasis on UI terms (Healthy, Flaky, Broken, Current, Proposed) is applied uniformly
Grammar and formatting are clean throughout the additions

Minor non-blocking observations (carried over from earlier reviews):

Slight phrasing variance between files in the tooltip description: failure-count-monitor.md says "the total that match the monitor configuration" while failure-rate-monitor.md says "the total matching the configuration" — both read fine.
failure-rate-monitor.md:183 references "not-in-window count" — assumed to match UI terminology; no change needed if so.

LGTM. Ready to merge.
| Branch

github-actions

Auto-approved: Claude code review passed.

samgutentag · 2026-05-06T22:11:09Z

Verification status (2026-05-07, re-verified): live

Verified: customers can use this. Ready to publish.

Eng PR: trunk2#3732 ("feat(preview-panels): add status filter dropdown to failure-count and threshold preview panels", merged 2026-04-27, merge commit still on main)
Linear ticket: none referenced
Flag: none (status filter dropdown ships unflagged)
Signals: pure frontend addition. Eng merge intact. No rollout to chase.

Branch is in publishable state:

Earlier Claude review nit (missing comma before "so" on failure-rate-monitor.md line 173) was resolved in 9fbb0aa and confirmed LGTM by two subsequent automated reviews.
2026-05-05 triage: "Review approved. Ready to merge."
Branch is 10 commits behind origin/main, but none of those 10 commits touch failure-count-monitor.md or failure-rate-monitor.md, so the lag is tangential. PR reports MERGEABLE/CLEAN; merging into main will not introduce conflicts.
Two non-blocking Claude observations (tooltip phrasing variance between the two files, "not-in-window count" terminology) were both flagged as fine across multiple review rounds. Leaving as-is.

Suggested next action: flip out of draft and merge. No remaining content work.

claude · 2026-05-07T08:05:00Z

Claude finished @samgutentag's task in 1m 39s —— View job

PR Review

Gather context
Read CLAUDE.md for repo guidelines
Review changed files for typos, grammar, and formatting
Post review findings

This trigger is from ready_for_review (draft → ready). No content changes since the prior approving reviews — the only commits since the last review are the merge from main (a9258ef) and a GitBook merge (e3cee08); neither touches failure-count-monitor.md or failure-rate-monitor.md.

Findings:

No blocking issues. Verified on the current diff:

failure-rate-monitor.md:173 — comma before "so" is in place ✓ (fixed in 9fbb0aa)
Heading capitalization (Title Case) is consistent within and across both files
Em-dash usage (—) is consistent and correct
Bold emphasis on UI terms (Healthy, Flaky, Broken, Current, Proposed) is applied uniformly
Grammar and formatting are clean throughout the additions

Minor non-blocking observations (carried over from earlier reviews):

Slight phrasing variance between files in the tooltip description: failure-count-monitor.md says "the total that match the monitor configuration" while failure-rate-monitor.md says "the total matching the configuration" — both read fine.
failure-rate-monitor.md:183 references "not-in-window count" — assumed to match UI terminology; no change needed if so.

LGTM. Ready to merge.
| Branch

github-actions

Auto-approved: Claude code review passed.

claude Bot reviewed Apr 28, 2026

View reviewed changes

Comment thread flaky-tests/detection/failure-rate-monitor.md Outdated

github-actions Bot approved these changes Apr 28, 2026

View reviewed changes

Merge branch 'main' into sam-gutentag/monitor-preview-panel-status-fi…

97d304c

…lter

github-actions Bot approved these changes May 5, 2026

View reviewed changes

Update flaky-tests/detection/failure-rate-monitor.md

9fbb0aa

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

github-actions Bot approved these changes May 6, 2026

View reviewed changes

Merge branch 'main' into sam-gutentag/monitor-preview-panel-status-fi…

a9258ef

…lter

github-actions Bot approved these changes May 6, 2026

View reviewed changes

samgutentag marked this pull request as ready for review May 7, 2026 08:04

trunk-staging-io Bot merged commit fa4aecd into main May 7, 2026
8 checks passed

trunk-staging-io Bot deleted the sam-gutentag/monitor-preview-panel-status-filter branch May 7, 2026 08:05

github-actions Bot approved these changes May 7, 2026

View reviewed changes

Conversation

samgutentag commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Source

Test plan

Uh oh!

trunk-staging-io Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

claude Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

samgutentag commented May 6, 2026

Uh oh!

claude Bot commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

claude Bot commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

samgutentag commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude Bot commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

samgutentag commented Apr 28, 2026 •

edited

Loading

trunk-staging-io Bot commented Apr 28, 2026 •

edited

Loading

claude Bot commented Apr 28, 2026 •

edited

Loading

claude Bot commented May 5, 2026 •

edited

Loading

claude Bot commented May 6, 2026 •

edited

Loading

claude Bot commented May 6, 2026 •

edited

Loading

samgutentag commented May 6, 2026 •

edited

Loading

claude Bot commented May 7, 2026 •

edited

Loading