Skip to content

docs(merge-queue): document metrics drill-down PR list#555

Open
samgutentag wants to merge 5 commits intomainfrom
sam-gutentag/merge-queue-metrics-drill
Open

docs(merge-queue): document metrics drill-down PR list#555
samgutentag wants to merge 5 commits intomainfrom
sam-gutentag/merge-queue-metrics-drill

Conversation

@samgutentag
Copy link
Copy Markdown
Member

Summary

  • Adds a new section to the Metrics and Monitoring page describing the metrics drill-down feature
  • Documents how to click a chart data point to view individual PRs for that time range
  • Covers filter options: date range, conclusion, impacted targets

Source

Test plan

  • Preview in GitBook

Adds a section to the Metrics and Monitoring page describing how to
click into a chart data point to view the individual PRs that make up
that metric, with filter options for date range, conclusion, and
impacted targets.

Source: trunk2 PR #3539

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@trunk-staging-io
Copy link
Copy Markdown

trunk-staging-io Bot commented Apr 17, 2026

✨ Submitted to Merge by Sam Gutentag (a GitHub user). It will be added to the merge queue once all branch protection rules pass and there are no merge conflicts with the target branch. See more details here.

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 5, 2026

Claude finished @samgutentag's task in 1m 12s —— View job


PR Review

  • Gather context
  • Read changed files
  • Check CLAUDE.md for repo guidelines
  • Review documentation for typos, grammar, and formatting
  • Post inline comments for specific issues
  • Provide final review summary

Summary

The PR adds a ### Drill into a metrics data point section with filter documentation. The content is accurate, but there are two issues worth addressing:

Blocking: Duplicate section
The page already has a ### Drill down into metrics section (lines 108–146) that covers the same feature in detail — with screenshots, "Why Drill Down?", "Select Data Points", and "Review the PR List" subsections. The new section is a shorter restatement of the same feature, which will confuse readers and fragment navigation. See inline comment at line 150.

Recommended fix: Move the new #### Filter the PR list content into the existing section (after #### Review the PR List) and drop the redundant wrapper section. The filter information is the genuinely new piece here.

Minor: Capitalization + wording (line 151)

  • "Conclusion Count" and "Time in Queue" should be "Conclusion count" and "Time in queue" to match usage elsewhere in the file.
  • "that point" → "that selection" (the feature supports drag-ranges, not just single clicks).

See inline comment at line 151 for a suggested replacement.

Comment thread merge-queue/administration/metrics.md Outdated
Comment thread merge-queue/administration/metrics.md Outdated
@samgutentag
Copy link
Copy Markdown
Member Author

Triage status (2026-05-05): up to date with main. Needs review before merge.

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 6, 2026

Claude finished @samgutentag's task in 1m 25s —— View job


PR Review

  • Gather context
  • Read changed files and current diff
  • Verify previous review feedback status
  • Check for typos, grammar, formatting
  • Post inline comments for any new issues
  • Provide final review summary

Summary

The diff to merge-queue/administration/metrics.md has not changed since the prior review on 2026-05-05 (only a main merge commit landed in between), so both previously flagged issues remain. I also noticed one small style consistency nit.

Blocking — duplicate section (line 150)
The new ### Drill into a metrics data point section overlaps the existing ### Drill down into metrics section (lines 108–146). The genuinely new content is the #### Filter the PR list block and the "Back to Health" tip — these should fold into the existing section rather than stand as a parallel h3.

Non-blocking — capitalization + wording (line 152)

  • Conclusion Count / Time in Queue → sentence case (Conclusion count, Time in queue) to match the rest of the file.
  • that pointthat selection to also cover drag-range selections.

Non-blocking — em-dash consistency (lines 160–162)
The new filter bullets use - for the term/definition split, but the adjacent existing section uses . Worth aligning when restructuring.

Net: content is accurate and the filter info is the right addition — the structural duplication is the one thing that should block merge.
| Branch

Comment thread merge-queue/administration/metrics.md Outdated
Comment thread merge-queue/administration/metrics.md Outdated
Comment thread merge-queue/administration/metrics.md Outdated
@samgutentag
Copy link
Copy Markdown
Member Author

samgutentag commented May 6, 2026

Verification status (2026-05-07): live

Verified: customers can use this. Ready to publish.

  • Eng PR: trunk-io/trunk2#3539 (merged 2026-04-16)
  • Linear: TRUNK-17995 (Done, completed 2026-04-22)
  • Flag: none (no LaunchDarkly gate found in PR body or diff)
  • Signals:
    • Merge commit on main (status: behind, merge intact)
    • No feature flag patterns in PR diff or product code (merge-metrics-pr-list.tsx)
    • Linear ticket is in Done status
    • No follow-up PRs adding filter UI to the PR list page

Branch is up to date with main. Note: original draft documented filter controls that do not exist in the implementation; corrected in 252984e.

samgutentag and others added 2 commits May 7, 2026 00:59
The original PR added a "### Drill into a metrics data point" section
that mostly duplicated the existing "### Drill down into metrics"
section above and described filter UI that does not exist.

Verified against trunk2: merge-metrics-pr-list.tsx (381 lines) has no
filter widgets. The conclusion and impactedTargets URL params are set
by the drill-down click flow on the Health charts, not by user-editable
controls on the PR list page.

Replaced the duplicate section with a sentence on the actual page
features: Back to Health navigation (lines 324, 358) and the 2,500-row
truncation behavior (constants: MAX_ITEMS = 2_500, FETCH_PAGE_SIZE = 250).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 7, 2026

PR Review

  • Gather context (read CLAUDE.md, current diff)
  • Read changed file in current state
  • Verify whether prior review feedback was addressed
  • Check for typos, grammar, formatting
  • Post inline comments for any new issues
  • Provide final review summary

View job run | Branch

@samgutentag samgutentag marked this pull request as ready for review May 7, 2026 08:06
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 7, 2026

PR Review

  • Gather context (read CLAUDE.md, current diff)
  • Read changed file in current state
  • Verify whether prior review feedback was addressed
  • Check for typos, grammar, formatting
  • Provide final review summary

View job run | Branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants