docs(merge-queue): document date range selection on health charts#535
Conversation
…h charts Users can now click and drag on any merge health chart to select a custom date range for focused inspection. Source: trunk2 PR #3489 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
😎 Merged successfully - details. |
|
Claude finished @samgutentag's task in 1m 3s —— View job PR Review
The new "Select a date range on a chart" section is clear and well-written. A couple of minor observations: 1. "span of bars" assumes bar charts only (line 78)
The heading says this works on "any merge health chart," but the page's own figure alt text shows a line chart ("Time in Queue p50 line chart"). "Bars" doesn't apply to line charts. Consider a more chart-agnostic phrasing:
2. Potential reader confusion with the existing "Drill down into metrics" section The existing Both are minor and non-blocking. The content is accurate, the section fits naturally between "Time buckets" and the UTC hint, and no grammar or formatting issues were found. |
|
Triage status (2026-05-05): up to date with main. Needs review before merge. |
|
Claude finished @samgutentag's task in 1m 21s —— View job PR Review
The new "Select a date range on a chart" section is well-placed (between Time buckets and the UTC hint) and the prose is clear. Posted four inline comments — one blocking-ish, three minor: Posted inline:
No typos, grammar, or formatting issues. The section flows naturally and the placement is sensible. |
|
|
||
| ### Select a date range on a chart | ||
|
|
||
| You can click and drag directly on any merge health chart to select a custom date range. Dragging across a span of bars highlights that window and zooms the view to show only data within the selected range. This lets you isolate a specific incident, deployment window, or performance regression for closer inspection. |
There was a problem hiding this comment.
"span of bars" assumes bar charts only. The opening sentence says this works on "any merge health chart," but the page's hero figure (line 7) describes a line chart (Time in Queue p50 line chart) — and the Time in queue chart at line 96 is a line chart. "Bars" doesn't apply there.
Consider chart-agnostic phrasing:
| You can click and drag directly on any merge health chart to select a custom date range. Dragging across a span of bars highlights that window and zooms the view to show only data within the selected range. This lets you isolate a specific incident, deployment window, or performance regression for closer inspection. | |
| You can click and drag directly on any merge health chart to select a custom date range. Dragging across a region of the chart highlights that window and zooms the view to show only data within the selected range. This lets you isolate a specific incident, deployment window, or performance regression for closer inspection. |
|
|
||
| ### Select a date range on a chart | ||
|
|
||
| You can click and drag directly on any merge health chart to select a custom date range. Dragging across a span of bars highlights that window and zooms the view to show only data within the selected range. This lets you isolate a specific incident, deployment window, or performance regression for closer inspection. |
There was a problem hiding this comment.
Possible conflict with the existing "Drill down into metrics" section. Further down the page (line 132), the docs already describe the same gesture — click and drag across the chart — but attribute a different outcome to it: a View PRs button surfaces and you can drill into the PR list.
This new section says the same gesture zooms the view. So the page now documents one gesture with two distinct effects, and a reader who reaches both sections will be confused about which actually happens (or whether both do).
A few options:
- Add a one-line cross-reference here, e.g. "This zooms the chart view; to open the PR list for a selected range, see Drill down into metrics."
- Confirm with engineering whether the gestures are truly distinct (e.g. drag vs. drag + click on the highlighted region), and disambiguate them in the prose.
- If the View PRs button now appears alongside the zoom, update both sections to reflect the unified behavior.
Worth resolving before merging — these two sections are only ~50 lines apart on the same page.
|
|
||
| ### Select a date range on a chart | ||
|
|
||
| You can click and drag directly on any merge health chart to select a custom date range. Dragging across a span of bars highlights that window and zooms the view to show only data within the selected range. This lets you isolate a specific incident, deployment window, or performance regression for closer inspection. |
There was a problem hiding this comment.
"any merge health chart" may overstate scope. The existing Drill down hint at line 150–152 explicitly notes:
Drill down is currently available on the Conclusion count and Time in queue charts. Additional Health charts will support the same interaction as they land in the UI.
If date-range zoom has the same per-chart limitation (likely, since it appears to share the underlying selection mechanism), saying "any merge health chart" will set the wrong expectation. Worth verifying with the source PR (trunk2#3489) and either narrowing the wording or adding a parallel hint.
|
|
||
| You can click and drag directly on any merge health chart to select a custom date range. Dragging across a span of bars highlights that window and zooms the view to show only data within the selected range. This lets you isolate a specific incident, deployment window, or performance regression for closer inspection. | ||
|
|
||
| To clear a selection and return to the full time range, click anywhere outside the selected area on the chart. |
There was a problem hiding this comment.
Verify the clear-selection gesture. "Click anywhere outside the selected area on the chart" is a specific claim — worth double-checking against the implementation. Common patterns for this kind of zoom UI are a dedicated Reset zoom button or a double-click, not an outside-click. If the actual mechanism differs, this instruction will frustrate users who try it and find nothing happens.
|
Verification status (2026-05-07, re-verified): Verified: customers can use this. Ready to publish.
Re-verification surfaced four accuracy issues in the original "Select a date range on a chart" section. All four addressed in commit
Cross-chart sync (selecting on one chart highlights the same range on the other) is also documented now since it's visible in the diff ( Standalone UTC hint moved up next to "Time buckets" since it is general date-filtering advice rather than range-selection-specific.
Suggested next action: flip out of draft and merge. |
… section Re-verification against trunk2#3489 surfaced four content issues with the standalone "Select a date range on a chart" section: it described "span of bars" though the feature works on the line chart too, claimed "any merge health chart" though only Conclusion count and Time in queue support it, said "click anywhere outside the selected area" to clear though the actual hook does not implement that gesture, and overlapped with the existing Drill down section that documents the same click and drag gesture for the View PRs outcome. Restructure folds the new affordances into the existing "Drill down into metrics > Select Data Points" subsection: the range-selection description now covers highlight and dim, cross-chart sync, and the real clear mechanism (drag a new range, or change time range, time bucket, or UTC setting). The standalone UTC hint moves up next to "Time buckets" since it is general date-filtering advice. The trailing hint is updated to mention range selection alongside drill down. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Claude finished @samgutentag's task in 2m 12s —— View job PR Review
The actual PR diff vs Verified against the diff:
Style and grammar: clean. No typos. Bold formatting on Time in UTC matches the existing convention at line 77. Pluralization of "interaction" → "interactions" in the hint is correct given two distinct interactions are now covered. One minor, non-blocking observation (not introduced by this PR): Lines 130 and 138 use "cancelled" (double-l) in the figure alt text and the Conclusion bullet, while the existing Conclusion count prose at line 82 and the table at line 88 use "canceled" (single-l). Both lines pre-date this PR (they came in via No blocking issues. Ready to merge. |

Summary
Source
Test plan