Audit and fix org slug terminology#522
Conversation
The GitHub Actions CI provider page told users to store secrets as TRUNK_ORG_URL_SLUG and TRUNK_API_TOKEN, but the code examples on the same page reference secrets.TRUNK_ORG_SLUG and secrets.TRUNK_TOKEN. A user following the instructions step by step would save the secret under one name and reference it under another. Changed to TRUNK_ORG_SLUG and TRUNK_TOKEN to match the code examples on the page and every other CI provider doc. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
😎 Merged successfully - details. |
|
Claude finished @samgutentag's task in 54s —— View job PR Review
The Fix (line 38) ✅The change is correct. The setup instructions now tell users to store secrets as Remaining Inconsistencies
|
|
Claude finished @samgutentag's task in 1m 3s —— View job PR Review
Blocking Issue: Unresolved Merge Conflict ❌The file contains unresolved git conflict markers at line 38 of The merge conflict was committed to the branch without being resolved. The The correct resolution is to keep the PR branch version ( Other ObservationsDuplicate intro paragraph (pre-existing, not introduced by this PR): Lines 7 and 11 are nearly identical:
One of these should be removed. Quarantining/token references: The rest of the file consistently uses The core intent of this PR (fixing the |
|
Claude finished @samgutentag's task in 1m 2s —— View job PR Review
Blocking Issue: Unresolved Merge Conflict ❌The file still contains unresolved git conflict markers at lines 38–42 of The The correct resolution is to keep the PR branch version ( Pre-existing Issue (not introduced by this PR)Duplicate intro paragraph at lines 7 and 11:
These two sentences are nearly identical and serve the same purpose. One should be removed. This is pre-existing and not a blocker for this PR, but worth cleaning up. What Was Confirmed Correct ✅
|
|
Triage status (2026-05-05): up to date with main. Pure bug fix (org slug terminology mismatch on GitHub Actions page). Safe to merge after a quick review. |
|
Verification status (2026-05-07, re-verified): Verified: customers can use this. The change itself is a pure docs terminology fix and is safe to publish.
Merge readiness (this is the part that needs attention):
Suggested next action: push |
|
Claude finished @samgutentag's task in 50s —— View job PR Review
Blocking Issue: Unresolved Merge Conflict ❌The file The The correct resolution is to keep the PR-branch version (
Pre-existing Nit (not introduced by this PR)Duplicate intro paragraph at lines 7 and 11 — these two sentences are nearly identical and serve the same purpose:
One should be removed. Not a blocker for this PR — flagging for visibility. What Was Confirmed Correct ✅
Summary: Blocking — the conflict markers must be removed before merging. Once that's done, the underlying change is correct and ready. |
| <<<<<<< samgutentag/org-slug-audit | ||
| Store the Trunk slug and API token obtained in the previous step in your repo as [GitHub secrets](https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions) named `TRUNK_ORG_SLUG` and `TRUNK_TOKEN` respectively. | ||
| ======= | ||
| Store the Trunk slug and API token obtained in the previous step in your repo as [GitHub secrets](https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions) named `TRUNK_ORG_URL_SLUG` and `TRUNK_TOKEN` respectively. | ||
| >>>>>>> main |
There was a problem hiding this comment.
Blocking: unresolved git merge conflict markers committed to the branch. These will render verbatim in the published docs. Keep the PR-branch version (TRUNK_ORG_SLUG) and remove the markers plus the main-side line.
| <<<<<<< samgutentag/org-slug-audit | |
| Store the Trunk slug and API token obtained in the previous step in your repo as [GitHub secrets](https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions) named `TRUNK_ORG_SLUG` and `TRUNK_TOKEN` respectively. | |
| ======= | |
| Store the Trunk slug and API token obtained in the previous step in your repo as [GitHub secrets](https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions) named `TRUNK_ORG_URL_SLUG` and `TRUNK_TOKEN` respectively. | |
| >>>>>>> main | |
| Store the Trunk slug and API token obtained in the previous step in your repo as [GitHub secrets](https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions) named `TRUNK_ORG_SLUG` and `TRUNK_TOKEN` respectively. |
Conflict markers from the prior merge were committed to the branch without resolution, which would render verbatim on the published page. Keeps the PR-side line (TRUNK_ORG_SLUG) per the original audit fix. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Two near-identical "Before you start these steps, see Test Frameworks" sentences existed at lines 7 and 11. Combined into one sentence after the integration paragraph so the flow is header to context to prereq. Pre-existing nit flagged by Claude reviewer three times on this PR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Claude finished @samgutentag's task in 55s —— View job PR Review
Status: Ready to Merge ✅Both previously-blocking issues have been resolved on this branch:
Net Diff vs.
|
Summary
Audited all org slug terminology across the docs for consistency. Searched every
.mdfile for:TRUNK_ORG_SLUG,TRUNK_ORG_URL_SLUG,org-url-slug,org-slug, and "organization slug".What was fixed
flaky-tests/get-started/ci-providers/github-actions.mdline 38 — The setup instructions told users to store GitHub secrets asTRUNK_ORG_URL_SLUGandTRUNK_API_TOKEN, but the code examples on the same page referencesecrets.TRUNK_ORG_SLUGandsecrets.TRUNK_TOKEN. A user following the instructions step by step would save the secret under one name and reference it under another. Changed toTRUNK_ORG_SLUGandTRUNK_TOKENto match the code examples and every other CI provider doc.What was confirmed correct
--org-url-slugconsistently (matches the actual binary flag).TRUNK_ORG_URL_SLUG: Used correctly in RSpec plugin examples where the CLI reads from environment (e.g.,TRUNK_ORG_URL_SLUG=$TRUNK_ORG_SLUG). These pass an arbitrary CI secret name into the real env var the CLI reads — correct pattern.org-slug:(matches action.yaml).<TRUNK_ORG_SLUG>used consistently as a human-readable template token in non-Action CLI examples.TRUNK_ORG_SLUG— no issues found.TRUNK_ORG_URL_SLUG=<TRUNK_ORG_URL_SLUG>(setting the real env var directly with a placeholder value).Open questions
None — the only issue found was the GitHub Actions page mismatch, which is now fixed.
🤖 Generated with Claude Code