tests: accept either attribution of the socket send warning - #224
Merged
Conversation
The write into the closed pipe runs either inside curl_exec() / curl_multi_exec() or from the event loop while the coroutine waits, and php_error_docref() prefixes the warning accordingly: the function name and the call site in the first case, "Unknown" and line 0 in the second. Both tests pinned the second form, so ALPINE_X64_DEBUG_ZTS failed in the OpCache step once the transfer finished synchronously.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ALPINE_X64_DEBUG_ZTSfailed in the OpCache step of run 31670068168 ontests/curl/054-multi_write_file_broken_pipe.phpt:The write into the closed pipe runs either inside
curl_multi_exec()or from the event loop while the coroutine waits incurl_multi_select().php_error_docref()names the active internal function when there is one and falls back toUnknownand line 0 when there is none, so both forms are correct and which one appears depends on when the transfer delivers its body. Both tests pinned the second form.The pattern now accepts either.
025-write_file_broken_pipe.phptcarries the same line and the same exposure, so it changes too.Checked on the local build: both tests pass plain, with
opcache.enable_cli=1, and withopcache.jit=tracing. The two other red tests intests/curl(063,064) fail only through theext/asyncsymlink, where../../../../ext/curl/tests/server.incdoes not resolve; they are green in CI.