Кучеренко А. - #2
Open
Sairen777 wants to merge 2 commits into
Open
Conversation
disturm
approved these changes
Mar 19, 2017
| var pointX = parseInt(document.getElementById("point-x").value); | ||
| var pointY = parseInt(document.getElementById("point-y").value); | ||
| var pointA = parseInt(document.getElementById("point-a").value); | ||
| window.point = {x: pointX, y: pointY, a: pointA}; |
There was a problem hiding this comment.
Явное создание глобальных переменных - ок. Но ты ведь мог обойтись одной.
window.task = {q: ..., n: ...};
Таким образом, ты бы и задачу решил и глобальный контекст меньше испачкал.
| document.getElementById("point-a").value = -45; | ||
| } | ||
|
|
||
| function transform() { |
There was a problem hiding this comment.
В этом методе у тебя 2 входных значения (newF, axiom) и 1 выходное - axiom. Очень легко обойтись без глобальный переменных и неявных связей. Вот и надо без них обходиться. Кстати, var result = axiom, а затем модифицирование этой копии как придется было бы правильнее. Сначала создай копию - а потом делай с ней, что хочешь.
| } | ||
|
|
||
| function build() { | ||
| getData(); |
There was a problem hiding this comment.
А еще круче было бы, чтобы
var data = GetData();
transform(data)
Это еще меньше глобальных переменных
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Выполнил задание